Fix Version/s: None
Remove all gen2 code from pipe_tasks.
DM-31047 Remove configuration from obs_* packages after Gen2 removal
- To Do
DM-35724 Remove gen2 from coadd_utils
DM-19374 pipe_task's optional dependency on ip_diffim isn't
- is triggering
DM-35871 Add refcat name arg to ReferenceObjectLoader init
- relates to
DM-35940 Cleanup return struct names
- To Do
DM-35939 Convert pipe_tasks to numpydoc and task topics
I have reviewed the PR for pipe_tasks.
EDIT: I have also done the PR for ci_hsc_gen3 and drp_pipe.
Eli Rykoff The APTemplate.yaml in ap_pipe assumes the old location of the makeWarp task, so that should be updated as well (I will pass it along to rest of the AP folks):
Good catch! I had done this but failed to make the PR, which is now here: https://github.com/lsst/ap_pipe/pull/123
I looked at the obs_cfht PR and think the fix is wrong and needs to go into obs_base. We also have some cruft processCcd.py and singleFrameDriver.py configs lying around in obs_cfht and obs_subaru (I have removed those for obs_lsst in another ticket).
I think everything is taken care of after Nate Lust clarified the supplementary data methods. I have a final jenkins here: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37169/pipeline (it all ran fine yesterday but I made more than just documentation changes in assembleCoadd and dcrAssembleCoadd in the meantime). Kenneth Herner, Tim Jenness thanks for the review! Please somebody click the "reviewed" button (or does one of you have to take your name off first?). Fingers crossed this will be in the new weekly!
There are a few PRs here.
The big one is pipe_tasks: https://github.com/lsst/pipe_tasks/pull/712
This deprecates the old location of MakeWarpTask and so I've updated to the new location:
And this update broke obs_cfht because (a) there was still a gen2 test there (oops) and the tests were relying on some side-effects to load detector tests; this makes the detector testing work correctly without side effects: https://github.com/lsst/obs_cfht/pull/105