[DM-35676] Fix the broken stellar locus plot in analysis_tools - Jira

XML

Word

Printable

Details

Type: Story
Status: Done
Resolution: Done
Fix Version/s: None
Component/s: None
Labels:
None

Story Points:
2
Epic Link:
f22a-drp-qa
Sprint:
Analysis Tools July 2022
Team:
Data Release Production
Urgent?:
No

Description

The stellar locus plots in analysis_tools are currently not working, make them work again.

Attachments

Activity

Hide

Permalink

Lee Kelvin added a comment - 21/Jul/22 7:04 PM

Looks good to me. A few comments on the ticket, one of which is to fix a flake8 (I suspect you've already fixed it by the time you read this), and the other two are regarding a potential future issue with names not displaying properly if self.identity is None. Happy to ignore this latter issue on this ticket, and address that in the future as/when it crops up. I ran your test script to confirm that all plots as expected: looks good to merge to me!

Show

Lee Kelvin added a comment - 21/Jul/22 7:04 PM Looks good to me. A few comments on the ticket, one of which is to fix a flake8 (I suspect you've already fixed it by the time you read this), and the other two are regarding a potential future issue with names not displaying properly if self.identity is None. Happy to ignore this latter issue on this ticket, and address that in the future as/when it crops up. I ran your test script to confirm that all plots as expected: looks good to merge to me!

People

Assignee:: Sophie Reed

Reporter:: Sophie Reed

Reviewers:: Lee Kelvin

Watchers:: Lee Kelvin, Nate Lust, Sophie Reed, Yusra AlSayyad

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 20/Jul/22 10:20 PM

Updated:: 01/Aug/22 9:26 PM

Resolved:: 22/Jul/22 7:57 PM

Jenkins

No builds found.

Data Management