Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35678

ts_MTAlignment is expecting the wrong replies from T2SA

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The T2SA prefixes most replies with "ACK-300 " or "ERR-nnn: " (but not necessarily the "EMP" reply) and the "READY" reply to "?STAT" has ";<date>" appended to it. The ts_MTAlignment code is not expecting these prefixes nor the extra data after READY.

      Also make the read timeout longer and disconnect if a command times out (to avoid reading replies from older commands).

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          rowen Russell Owen added a comment - - edited

          Pull requests:

          Show
          rowen Russell Owen added a comment - - edited Pull requests: https://github.com/lsst-ts/ts_MTAlignment/pull/12 https://github.com/lsst-ts/ts_config_mttcs/pull/40
          Hide
          Permalink
          tribeiro Tiago Ribeiro added a comment -

          PR reviewed/approved in GH.

          Show
          tribeiro Tiago Ribeiro added a comment - PR reviewed/approved in GH.
          Hide
          Permalink
          rowen Russell Owen added a comment - - edited

          Based on the review and post-review discussions I made some significant enhancements, so I am putting this back into review. The additional changes include:

          • Change config schema version to v3. Add read_timeout and targets fields. Also rename t2sa_ip to {{t2sa_host}.
          • AlignmentModel: add measure_target, get_target_offset, and get_target_position commands and ditch the target-specific variants. Rename all remaining query_x to get_x.
          • Log a warning if any reply takes longer than 5 seconds (a module constant). The log message includes the time taken, the command and the reply. I hope this will help us understand why some responses are so slow.
          Show
          rowen Russell Owen added a comment - - edited Based on the review and post-review discussions I made some significant enhancements, so I am putting this back into review. The additional changes include: Change config schema version to v3. Add read_timeout and targets fields. Also rename t2sa_ip to {{t2sa_host}. AlignmentModel: add measure_target, get_target_offset, and get_target_position commands and ditch the target-specific variants. Rename all remaining query_x to get_x. Log a warning if any reply takes longer than 5 seconds (a module constant). The log message includes the time taken, the command and the reply. I hope this will help us understand why some responses are so slow.
          Hide
          Permalink
          tribeiro Tiago Ribeiro added a comment -

          PRs reviewed/approved in GH

          Show
          tribeiro Tiago Ribeiro added a comment - PRs reviewed/approved in GH
          Hide
          Permalink
          rowen Russell Owen added a comment - - edited

          Thank you for the helpful review. I made all your suggested changes.

          Released ts_MTAlignment v0.2.0 and ts_config_mttcs v0.9.0

          Show
          rowen Russell Owen added a comment - - edited Thank you for the helpful review. I made all your suggested changes. Released ts_MTAlignment v0.2.0 and ts_config_mttcs v0.9.0

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Tiago Ribeiro
            Watchers:
            Dave Mills, Petr Kubanek, Russell Owen, Tiago Ribeiro
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.