Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ctrl_mpexec, pipe_base
-
Story Points:1
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
See https://lsstc.slack.com/archives/C2JPT1KB7/p1658356940879239
Basic fix is trivial, but I'll also see if I can ward off future similar problems by making the universe ctor argument non-optional and checking it against the things within the QG that also have a universe.
Attachments
Activity
Just a couple questions probably more for my info than anything about the code itself. I don't know all of this code so there may be some location that was missed. But I ran the pipe_base and bps unit tests which were all fine. Also I submitted a test run on the idf that had the warning before and now it doesn't and pipetaskInit ran fine (with no universe warnings). Merge approved.
ctrl_mpexec did indeed need some test changes: https://github.com/lsst/ctrl_mpexec/pull/197
Michelle Gower, could you review?
PR is https://github.com/lsst/pipe_base/pull/265
There's non-negligible chance this will require changes to downstream tests, especially in ctrl_mpexec (Jenkins is still running).
(Nate Lust, you're of course welcome to take a look, too, but I know you've got other priorities this week and the changes here to the QG class and it helpers seemed pretty straightforward.)