Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35681

Ensure DimensionUniverse is passed to QuantumGraph at construction

    XMLWordPrintable

Details

    Description

      See https://lsstc.slack.com/archives/C2JPT1KB7/p1658356940879239

      Basic fix is trivial, but I'll also see if I can ward off future similar problems by making the universe ctor argument non-optional and checking it against the things within the QG that also have a universe.

      Attachments

        Activity

          jbosch Jim Bosch added a comment -

          mgower, could you review?

          PR is https://github.com/lsst/pipe_base/pull/265

          There's non-negligible chance this will require changes to downstream tests, especially in ctrl_mpexec (Jenkins is still running).

          (nlust, you're of course welcome to take a look, too, but I know you've got other priorities this week and the changes here to the QG class and it helpers seemed pretty straightforward.)

          jbosch Jim Bosch added a comment - mgower , could you review? PR is https://github.com/lsst/pipe_base/pull/265 There's non-negligible chance this will require changes to downstream tests, especially in ctrl_mpexec (Jenkins is still running). ( nlust , you're of course welcome to take a look, too, but I know you've got other priorities this week and the changes here to the QG class and it helpers seemed pretty straightforward.)

          Just a couple questions probably more for my info than anything about the code itself. I don't know all of this code so there may be some location that was missed. But I ran the pipe_base and bps unit tests which were all fine. Also I submitted a test run on the idf that had the warning before and now it doesn't and pipetaskInit ran fine (with no universe warnings).  Merge approved. 

           

           

          mgower Michelle Gower added a comment - Just a couple questions probably more for my info than anything about the code itself. I don't know all of this code so there may be some location that was missed. But I ran the pipe_base and bps unit tests which were all fine. Also I submitted a test run on the idf that had the warning before and now it doesn't and pipetaskInit ran fine (with no universe warnings).  Merge approved.     
          jbosch Jim Bosch added a comment -

          ctrl_mpexec did indeed need some test changes: https://github.com/lsst/ctrl_mpexec/pull/197

          jbosch Jim Bosch added a comment - ctrl_mpexec did indeed need some test changes: https://github.com/lsst/ctrl_mpexec/pull/197

          People

            jbosch Jim Bosch
            jbosch Jim Bosch
            Michelle Gower
            Jim Bosch, Michelle Gower
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.