Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:
-
Story Points:0
-
Epic Link:
-
Sprint:TSSW Sprint - Jul 18 - Aug 01
-
Team:Telescope and Site
-
Urgent?:No
Description
Currently ESS:1 has the name "CamHex_CCW-ESS01" but this is incorrect since it is for the hexapod/rotator and not the camera cable wrap (which CCW means). This ticket is for changing it into a more meaningful name.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Summary | Modify the name of ESS:1 | Modify the name of the sensor connected to ESS:1 |
I suggest MTCamHex_Rot instead of Cam_HexRot. It's the only sensor name missing a leading AuxTel or MT.
It's also worth considering standardizing the prefixes on all sensor name that are telescope-specific s, e.g. MT/AT or MainTel/AuxTel. I realize that would be more disruptive than just changing this one name.
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
The other sensors are named MTDome-ESSXX and AuxTel-ESSXX. The challenge with the AuxTel ones is that some sensors get telemetry from the dome environment and from the telescope at the same time so naming them ATDome-ESSXX and AT-ESSXX is not possible. The LabJack sensors have yet another naming convention. I suggest we leave this all as is.
For the HexRot sensor I propose MTCamHexRot-ESSXX.
ts_config_ocs PR: https://github.com/lsst-ts/ts_config_ocs/pull/95
| Reviewers | Russell Owen [ rowen ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
How about MTCameraAssembly instead?
| Watchers | Chris Walter, Russell Owen, Tiago Ribeiro, Wouter van Reeven [ Chris Walter, Russell Owen, Tiago Ribeiro, Wouter van Reeven ] | Brian Stalder, Chris Walter, Russell Owen, Tiago Ribeiro, Wouter van Reeven [ Brian Stalder, Chris Walter, Russell Owen, Tiago Ribeiro, Wouter van Reeven ] |
Brian Stalder and Chris Walter, can you please comment on the name-choice please?
Brian Stalder Chris Walter Any preference for a name?
no preference, though I would like as standard format as possible with other ESS Pi's...
Yes, I agree making it as much like the pattern of the others is best.
I think Tiago's suggestions of MTCameraAssembly is good in that it easily incorporates any ESS sensor you put into the entire structure.
Chris Walter
added a comment - Yes, I agree making it as much like the pattern of the others is best.
I think Tiago's suggestions of MTCameraAssembly is good in that it easily incorporates any ESS sensor you put into the entire structure. Reviewed on github
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
The sensor now is called MTCameraAssembly-ESS01.
To be clear, for tests now does it already have this new name? Or is will have it after the next cycle?
Chris Walter
added a comment - To be clear, for tests now does it already have this new name? Or is will have it after the next cycle? Sorry, I don't know if it has been deployed to TTS already. It will be deployed to the summit as soon as we are up and running again.
Would Cam_HexRot-ESS01 be a better name for this sensor?