Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35718

bypass functions do not play well with datasetExists (in gen2)

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • daf_persistence
    • None
    • External
    • No

    Description

      PFS is still using gen2, and uses a bypass_raw function to handle H4RG detectors. This doesn't work with butler.datasetExists (and thus not with cmdLineTask).

      Please provide a bypass function to test for file existence.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          tjenness Tim Jenness added a comment -

          Did you mean to assign this to team External and assign to price? The only remaining gen2 code on main is in pipe_base and that is being removed in DM-35675 – obs_base does not have any gen2 code in it and no-one is supporting daf_persistence any more.

          tjenness Tim Jenness added a comment - Did you mean to assign this to team External and assign to price ? The only remaining gen2 code on main is in pipe_base and that is being removed in DM-35675 – obs_base does not have any gen2 code in it and no-one is supporting daf_persistence any more.
          rhl Robert Lupton added a comment -

          Pushed and created a PR

          rhl Robert Lupton added a comment - Pushed and created a PR
          ktl Kian-Tat Lim added a comment - - edited

          Since this code is going away, I don't think you need to push upstream to LSST (and I presume you aren't generally merging upstream to the PFS fork). I think you should make this change only locally in PFS.

          ktl Kian-Tat Lim added a comment - - edited Since this code is going away, I don't think you need to push upstream to LSST (and I presume you aren't generally merging upstream to the PFS fork). I think you should make this change only locally in PFS.
          price Paul Price added a comment -

          Completed review on GitHub PR, but we need to discuss how to handle this update given that Gen2 is almost dead.

          price Paul Price added a comment - Completed review on GitHub PR, but we need to discuss how to handle this update given that Gen2 is almost dead.
          rhl Robert Lupton added a comment -

          We know that there is no gen2 code support on Rubin mainline, so do not plan to merge this changeset. Up to Paul to decide how to handle it, but I believe that he prefers not to fork. I've assigned it to Team External as requested.

          rhl Robert Lupton added a comment - We know that there is no gen2 code support on Rubin mainline, so do not plan to merge this changeset. Up to Paul to decide how to handle it, but I believe that he prefers not to fork. I've assigned it to Team External as requested.
          tjenness Tim Jenness added a comment -

          Is this ticket still active?

          tjenness Tim Jenness added a comment - Is this ticket still active?
          price Paul Price added a comment -

          This was fixed on a branch, which was then ported to a monkeypatch in the PFS code. We have no intention of taking this any further.

          price Paul Price added a comment - This was fixed on a branch, which was then ported to a monkeypatch in the PFS code. We have no intention of taking this any further.

          People

            rhl Robert Lupton
            rhl Robert Lupton
            Paul Price
            Kian-Tat Lim, Paul Price, Robert Lupton, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.