Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35753

Fix chiller alarm parsing

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_auxiliary_telescope
    • Labels:
      None

      Description

      Fix two errors in ts_atwhitelight:

      • The chiller error codes are in the reverse order of an ordinary hex number. Reverse them before parsing them (that is probably simpler than changing the existing hex constants in ts_xml and ts_idl).
      • The chiller client logs the command bytes twice, once correctly and once with message "Read reply". Fix the second one to actually be the reply. Also eliminate the "Read reply" message in the model; we only need to log it once.
      • Also prevent the CSC from going to FAULT if already in FAULT (avoiding many unnecessary and confusing messages and a new error code).

        Attachments

          Issue Links

          is child task of

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. CAP-931 Catch all ticket for TSSW XML 13.0 work

          • Undefined - No priority assigned (may not apply or be unknown)
          • Done
          mitigates

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35679 ts_atwhitelight freezing after chiller goes to alarm state

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            I also provided the best workaround I could think of for the chiller "mode mismatch alarm" issue DM-35679: turn cooling off as soon as the watchdog data indicates an alarm. See the updated developer guide for a more complete explanation. ThermoTek says that should work, and that they will fix their bug.

            Ready for review, but I would prefer to test it first.

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited I also provided the best workaround I could think of for the chiller "mode mismatch alarm" issue DM-35679 : turn cooling off as soon as the watchdog data indicates an alarm. See the updated developer guide for a more complete explanation. ThermoTek says that should work, and that they will fix their bug. Ready for review, but I would prefer to test it first. Pull requests: https://github.com/lsst-ts/ts_atwhitelight/pull/22 https://github.com/lsst-ts/ts_idl/pull/95 https://github.com/lsst-ts/ts_xml/pull/605 (merged)
            Hide
            Permalink
            aclements Andy Clements added a comment -

            Whitelight epic is complete, moving this to the LSP Integration epic

            Show
            aclements Andy Clements added a comment - Whitelight epic is complete, moving this to the LSP Integration epic
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            Reviewed on GitHub.

            Maybe link this ticket to CAP-931 because of the ts_xml PR?

            Show
            wvreeven Wouter van Reeven added a comment - Reviewed on GitHub. Maybe link this ticket to CAP-931 because of the ts_xml PR?
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Linked this ticket to CAP-931.

            Tagged ts_idl v4.0.1 and ts_atwhitelight v0.2.1.

            Show
            rowen Russell Owen added a comment - Linked this ticket to CAP-931 . Tagged ts_idl v4.0.1 and ts_atwhitelight v0.2.1.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Wouter van Reeven
              Watchers:
              Andy Clements, Parker Fagrelius, Patrick Ingraham, Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.