Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_auxiliary_telescope
-
Labels:None
-
Story Points:2
-
Sprint:TSSW Sprint - Aug 01 - Aug 15
-
Team:Telescope and Site
-
Urgent?:No
Description
Fix two errors in ts_atwhitelight:
- The chiller error codes are in the reverse order of an ordinary hex number. Reverse them before parsing them (that is probably simpler than changing the existing hex constants in ts_xml and ts_idl).
- The chiller client logs the command bytes twice, once correctly and once with message "Read reply". Fix the second one to actually be the reply. Also eliminate the "Read reply" message in the model; we only need to log it once.
- Also prevent the CSC from going to FAULT if already in FAULT (avoiding many unnecessary and confusing messages and a new error code).
I also provided the best workaround I could think of for the chiller "mode mismatch alarm" issue
DM-35679: turn cooling off as soon as the watchdog data indicates an alarm. See the updated developer guide for a more complete explanation. ThermoTek says that should work, and that they will fix their bug.Ready for review, but I would prefer to test it first.
Pull requests: