Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35767

Add a constructor arg to salobj Controller, BaseCsc, and ConfigurableCsc that allows missing commands

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      TSSW Sprint - Oct 10 - Oct 24
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Add a constructor argument to salobj Controller and BaseCsc that allows commands to be missing (but still requires that any existing do_x methods have corresponding cmd_ topics). Other commands should raise salobjExpectedError with a message "not implemented". This will make it much easier to write minimal mock controllers, since they only have to implement the few commands they actually mock.

      Update ts_atdometrajectory and ts_mtdometrajectory to use these. Look at ts_mtmount and ts_mtrotator as well.

        Attachments

          Issue Links

          is child task of

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35787 Release RO's packages awaiting ts_xml 12.1/13 and the next cycle build

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-36588 Please rename 2 packages in ts_cycle_build and add ts_fiberspectrograph

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            I also renamed ts_ATDomeTrajectory to ts_atdometrajectory and changed HOME to WHOME in the Jenkinsfile for that package. I will rename the package on github and update the JIRA label after merging this ticket.

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited I also renamed ts_ATDomeTrajectory to ts_atdometrajectory and changed HOME to WHOME in the Jenkinsfile for that package. I will rename the package on github and update the JIRA label after merging this ticket. Pull requests: https://github.com/lsst-ts/ts_salobj/pull/257 https://github.com/lsst-ts/ts_ATDomeTrajectory/pull/50 https://github.com/lsst-ts/ts_mtdometrajectory/pull/31
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            All PRs reviewed on GitHub.

            Show
            wvreeven Wouter van Reeven added a comment - All PRs reviewed on GitHub.
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            All three packages merged to develop. ts_atdometrajectory renamed on github and labels renamed on Jira. We may wait to release until the next cycle build (DM-35787).

            Show
            rowen Russell Owen added a comment - - edited All three packages merged to develop. ts_atdometrajectory renamed on github and labels renamed on Jira. We may wait to release until the next cycle build ( DM-35787 ).

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Wouter van Reeven
              Watchers:
              Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.