Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35798

Add isort and other pre-commit hooks to the TSSW projects

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      isort is a python package to automatically sort python imports. This ticket is for adding isort and other pre-commit hooks to the TSSW projects. In order to do that, I will create a Confluence page describing what is needed to get this working.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          wvreeven Wouter van Reeven added a comment - - edited

          https://confluence.lsstcorp.org/display/LTS/TSSW+pre-commit+hooks

          Show
          wvreeven Wouter van Reeven added a comment - - edited https://confluence.lsstcorp.org/display/LTS/TSSW+pre-commit+hooks
          Hide
          Permalink
          wvreeven Wouter van Reeven added a comment -

          Please review the Confluence page and provide me with feedback to improve it.

          Show
          wvreeven Wouter van Reeven added a comment - Please review the Confluence page and provide me with feedback to improve it.
          Hide
          Permalink
          mareuter Michael Reuter added a comment -

          In the isort section there's this statement: touches the files in the python and test directories. However, I don't see anything in the pyproject.toml settings that indicates this or is it just an automatic assumption?

          Show
          mareuter Michael Reuter added a comment - In the isort section there's this statement: touches the files in the python and test directories. However, I don't see anything in the pyproject.toml settings that indicates this or is it just an automatic assumption?
          Hide
          Permalink
          wvreeven Wouter van Reeven added a comment - - edited

          Thanks for catching that. It actually touches all Python files in the project, including the doc and root directories. I have modifed the text accordingly.

          Show
          wvreeven Wouter van Reeven added a comment - - edited Thanks for catching that. It actually touches all Python files in the project, including the doc and root directories. I have modifed the text accordingly.
          Hide
          Permalink
          mareuter Michael Reuter added a comment -

          Page reviewed and looks good to release.

          Show
          mareuter Michael Reuter added a comment - Page reviewed and looks good to release.

            People

            Assignee:
            wvreeven Wouter van Reeven
            Reporter:
            wvreeven Wouter van Reeven
            Reviewers:
            Michael Reuter, Tiago Ribeiro
            Watchers:
            Michael Reuter, Tiago Ribeiro, Wouter van Reeven
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.