Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Story Points:1
-
Sprint:TSSW Sprint - Aug 01 - Aug 15
-
Team:Telescope and Site
-
Urgent?:No
Description
isort is a python package to automatically sort python imports. This ticket is for adding isort and other pre-commit hooks to the TSSW projects. In order to do that, I will create a Confluence page describing what is needed to get this working.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Summary | Add isort to the develop-env | Add isort and other pre-commit hooks to the TSSW projects |
| Description | {{isort}} is a python package to automatically sort python imports. This ticket is for adding isort to the develop-env docker image. | {{isort}} is a python package to automatically sort python imports. This ticket is for adding isort and other pre-commit hooks to the TSSW projects. In order to do that, I will create a Confluence page describing what is needed to get this working. |
Please review the Confluence page and provide me with feedback to improve it.
| Reviewers | Michael Reuter, Tiago Ribeiro [ mareuter, tribeiro ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
In the isort section there's this statement: touches the files in the python and test directories. However, I don't see anything in the pyproject.toml settings that indicates this or is it just an automatic assumption?
Thanks for catching that. It actually touches all Python files in the project, including the doc and root directories. I have modifed the text accordingly.
Page reviewed and looks good to release.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
https://confluence.lsstcorp.org/display/LTS/TSSW+pre-commit+hooks