Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35836

Deprecate config.cycleNumber which is incorrectly used.

    XMLWordPrintable

    Details

      Description

      In DM-971, John Parejko has noticed that fgcmcal is incorrectly modifying a config on validation. This operation is basically incorrect. The correct config to set is config.connections.cycleNumber and config.cycleNumber will be deprecated.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          erykoff Eli Rykoff added a comment -

          This should take care of your problems for DM-971.

          PRs:
          https://github.com/lsst/fgcmcal/pull/88
          https://github.com/lsst/obs_subaru/pull/429
          https://github.com/lsst/drp_pipe/pull/36

          Jenkins:
          https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37139/pipeline

          Show
          erykoff Eli Rykoff added a comment - This should take care of your problems for DM-971 . PRs: https://github.com/lsst/fgcmcal/pull/88 https://github.com/lsst/obs_subaru/pull/429 https://github.com/lsst/drp_pipe/pull/36 Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37139/pipeline
          Hide
          Permalink
          Parejkoj John Parejko added a comment -

          My only concerns are that a default jenkins run doesn't actually test the DRP pipeline, and I think ci_hsc doesn't run fgcmcal, and you'll need a triggered ticket for the removal of the config field (I wish we had release tickets filed well in advance that we could link to as blocked on removals).

          Show
          Parejkoj John Parejko added a comment - My only concerns are that a default jenkins run doesn't actually test the DRP pipeline, and I think ci_hsc doesn't run fgcmcal, and you'll need a triggered ticket for the removal of the config field (I wish we had release tickets filed well in advance that we could link to as blocked on removals).
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          DM-32971 is for release 25, DM-31706 is release 24.

          Do you need a release 26 ticket?

          Show
          tjenness Tim Jenness added a comment - DM-32971 is for release 25, DM-31706 is release 24. Do you need a release 26 ticket?

            People

            Assignee:
            erykoff Eli Rykoff
            Reporter:
            erykoff Eli Rykoff
            Reviewers:
            John Parejko
            Watchers:
            Eli Rykoff, John Parejko, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.