Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35852

Adapt the TSSW Pre-Commit Hooks

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_main_telescope
    • Labels:

      Description

      Adapt the TSSW pre-commit hooks based on TSSW pre-commit hooks.

      Use this chance to fix the bug in test_csc.py in ts_m2:

      self.assertLess(abs(zenith_angle.inclinometerRaw - elevation - 1), 3)

      If the CPU is slow, the above test will fail in Jenkins.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          ttsai Te-Wei Tsai added a comment -

          Please help to review the PRs:
          1. https://github.com/lsst-ts/ts_m2com/pulls
          2. https://github.com/lsst-ts/ts_m2/pulls
          3. https://github.com/lsst-ts/ts_m2gui/pulls

          There is the commit to just apply the isort and you can ignore the details in that specific commit.

          Thanks!

          Show
          ttsai Te-Wei Tsai added a comment - Please help to review the PRs: 1. https://github.com/lsst-ts/ts_m2com/pulls 2. https://github.com/lsst-ts/ts_m2/pulls 3. https://github.com/lsst-ts/ts_m2gui/pulls There is the commit to just apply the isort and you can ignore the details in that specific commit. Thanks!
          Hide
          Permalink
          wvreeven Wouter van Reeven added a comment -

          Reviewed on GitHub.

          Show
          wvreeven Wouter van Reeven added a comment - Reviewed on GitHub.

            People

            Assignee:
            ttsai Te-Wei Tsai
            Reporter:
            ttsai Te-Wei Tsai
            Reviewers:
            Wouter van Reeven
            Watchers:
            Te-Wei Tsai, Wouter van Reeven
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.