Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35852

Adapt the TSSW Pre-Commit Hooks

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_main_telescope
    • Labels:

      Description

      Adapt the TSSW pre-commit hooks based on TSSW pre-commit hooks.

      Use this chance to fix the bug in test_csc.py in ts_m2:

      self.assertLess(abs(zenith_angle.inclinometerRaw - elevation - 1), 3)
      

      If the CPU is slow, the above test will fail in Jenkins.

        Attachments

          Activity

          No builds found.
          ttsai Te-Wei Tsai created issue -
          ttsai Te-Wei Tsai made changes -
          Field Original Value New Value
          Sprint TSSW Sprint - Aug 01 - Aug 15 [ 1182 ] TSSW Sprint - Aug 15 - Aug 29 [ 1183 ]
          ttsai Te-Wei Tsai made changes -
          Description Adapt the TSSW pre-commit hooks based on [TSSW pre-commit hooks|https://confluence.lsstcorp.org/display/LTS/TSSW+pre-commit+hooks]. Adapt the TSSW pre-commit hooks based on [TSSW pre-commit hooks|https://confluence.lsstcorp.org/display/LTS/TSSW+pre-commit+hooks].

          Use this chance to fix the bug in *test_csc.py* in *ts_m2*:

          {code:python}
          self.assertLess(abs(zenith_angle.inclinometerRaw - elevation - 1), 3)
          {code}

          If the CPU is slow, the above test will fail in Jenkins.
          ttsai Te-Wei Tsai made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          ttsai Te-Wei Tsai made changes -
          Story Points 0
          Labels M2
          ttsai Te-Wei Tsai made changes -
          Story Points 0 1
          Hide
          ttsai Te-Wei Tsai added a comment -

          Please help to review the PRs:
          1. https://github.com/lsst-ts/ts_m2com/pulls
          2. https://github.com/lsst-ts/ts_m2/pulls
          3. https://github.com/lsst-ts/ts_m2gui/pulls

          There is the commit to just apply the isort and you can ignore the details in that specific commit.

          Thanks!

          Show
          ttsai Te-Wei Tsai added a comment - Please help to review the PRs: 1. https://github.com/lsst-ts/ts_m2com/pulls 2. https://github.com/lsst-ts/ts_m2/pulls 3. https://github.com/lsst-ts/ts_m2gui/pulls There is the commit to just apply the isort and you can ignore the details in that specific commit. Thanks!
          ttsai Te-Wei Tsai made changes -
          Reviewers Wouter van Reeven [ wvreeven ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          Hide
          wvreeven Wouter van Reeven added a comment -

          Reviewed on GitHub.

          Show
          wvreeven Wouter van Reeven added a comment - Reviewed on GitHub.
          wvreeven Wouter van Reeven made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          ttsai Te-Wei Tsai made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          aclements Andy Clements made changes -
          Epic Link DM-27720 [ 442125 ] DM-27721 [ 442128 ]

            People

            Assignee:
            ttsai Te-Wei Tsai
            Reporter:
            ttsai Te-Wei Tsai
            Reviewers:
            Wouter van Reeven
            Watchers:
            Te-Wei Tsai, Wouter van Reeven
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.