Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_main_telescope
-
Labels:None
-
Story Points:1
-
Sprint:TSSW Sprint - Aug 01 - Aug 15, TSSW Sprint - Aug 15 - Aug 29
-
Team:Telescope and Site
-
Urgent?:No
Description
M1M3 SS CSC doesn't send applied*Forces events when forces are zeroed - the zeroing is in fact handled in ForceController via calling disable method:
void ForceController::zeroStaticForces() { |
SPDLOG_INFO("ForceController: zeroStaticForces()"); |
if (_staticForceComponent.isEnabled()) { |
_staticForceComponent.disable();
|
}
|
}
|
where disable method doesn't put zeroes into force vector, and doesn't call logApplied*Forces to publish the change. Fix that by moving zero*Forces into ForceComponent, add code to actually put 0 into message, and sends the message out so it gets logged into EFD.
Also apply method check for enabled (and enable call) can be moved into force component, as when applying the forces, we would like to see them enabled:
void ForceController::applyStaticForces() { |
SPDLOG_INFO("ForceController: applyStaticForces()"); |
if (!_staticForceComponent.isEnabled()) { |
_staticForceComponent.enable();
|
}
|
_staticForceComponent.applyStaticForces(&_forceActuatorSettings->StaticXTable,
|
&_forceActuatorSettings->StaticYTable,
|
&_forceActuatorSettings->StaticZTable);
|
}
|
Attachments
Issue Links
- is triggered by
-
DM-35056 Convert M1M3 topics streaming topics from events to telemetry
- Done
Activity
Petr Kubanek
created issue -
Petr Kubanek
made changes -
Petr Kubanek
made changes -
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
Petr Kubanek
made changes -
| Sprint | TSSW Sprint - Aug 01 - Aug 15 [ 1182 ] | |
| Story Points | 1 |
Petr Kubanek
made changes -
| Epic Link | DM-27720 [ 442125 ] |
Petr Kubanek
made changes -
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Sprint | TSSW Sprint - Aug 01 - Aug 15 [ 1182 ] | TSSW Sprint - Aug 01 - Aug 15, TSSW Sprint - Aug 15 - Aug 29 [ 1182, 1183 ] |
Reviewd in github
Petr Kubanek
added a comment - Reviewd in github Petr Kubanek
made changes -
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Petr Kubanek
made changes -
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
Please see GH PR.