Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35882

Integrate the M2 Python EUI with Common Module in Phase 1

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_main_telescope
    • Labels:

      Description

      Integrate the M2 Python EUI (ts_m2gui) with common module (ts_m2com) in phase 1. This is to reuse the controller in common module (which has been used in the M2 CSC, ts_m2). By doing this, the M2 Python EUI should be able to support the simulation mode and verify its functionality.

      The main point in this phase 1 is to remove the duplicated code in ts_m2gui and adapt the qasync.

        Attachments

          Issue Links

            Activity

            No builds found.
            ttsai Te-Wei Tsai created issue -
            ttsai Te-Wei Tsai made changes -
            Field Original Value New Value
            Status To Do [ 10001 ] In Progress [ 3 ]
            ttsai Te-Wei Tsai made changes -
            Story Points 1
            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            I realized the pytest-qt and qasync can not be used at the same time for the event loop. The pytest-qt is just a wrapper of QtTest in PySide2. Therefore, it does not recognize the syntax of async or asyncSlot().

            One possible work-around is to write a simple function to update the existed code when doing the unit test.

            Show
            ttsai Te-Wei Tsai added a comment - - edited I realized the pytest-qt and qasync can not be used at the same time for the event loop. The pytest-qt is just a wrapper of QtTest in PySide2 . Therefore, it does not recognize the syntax of async or asyncSlot() . One possible work-around is to write a simple function to update the existed code when doing the unit test.
            ttsai Te-Wei Tsai made changes -
            Summary Integrate the M2 Python EUI with Common Module Integrate the M2 Python EUI with Common Module in Phase 1
            ttsai Te-Wei Tsai made changes -
            Description Integrate the M2 Python EUI (ts_m2gui) with common module (ts_m2com). This is to reuse the controller in common module (which has been used in the M2 CSC, ts_m2). By doing this, the M2 Python EUI should be able to support the simulation mode and verify its functionality. Integrate the M2 Python EUI (ts_m2gui) with common module (ts_m2com) in phase 1. This is to reuse the controller in common module (which has been used in the M2 CSC, ts_m2). By doing this, the M2 Python EUI should be able to support the simulation mode and verify its functionality.

            The main point in this phase 1 is to remove the duplicated code in ts_m2gui and adapt the *qasync*.
            ttsai Te-Wei Tsai made changes -
            Description Integrate the M2 Python EUI (ts_m2gui) with common module (ts_m2com) in phase 1. This is to reuse the controller in common module (which has been used in the M2 CSC, ts_m2). By doing this, the M2 Python EUI should be able to support the simulation mode and verify its functionality.

            The main point in this phase 1 is to remove the duplicated code in ts_m2gui and adapt the *qasync*.
            Integrate the M2 Python EUI (*ts_m2gui*) with common module (*ts_m2com*) in phase 1. This is to reuse the controller in common module (which has been used in the M2 CSC, *ts_m2*). By doing this, the M2 Python EUI should be able to support the simulation mode and verify its functionality.

            The main point in this phase 1 is to remove the duplicated code in *ts_m2gui* and adapt the *qasync*.
            ttsai Te-Wei Tsai made changes -
            Story Points 1 2
            ttsai Te-Wei Tsai made changes -
            Story Points 2 3
            Hide
            ttsai Te-Wei Tsai added a comment -

            Created the issue in pytest-qt for this:
            https://github.com/pytest-dev/pytest-qt/issues/448

            Show
            ttsai Te-Wei Tsai added a comment - Created the issue in pytest-qt for this: https://github.com/pytest-dev/pytest-qt/issues/448
            Hide
            ttsai Te-Wei Tsai added a comment -

            Please help to review the PR:
            https://github.com/lsst-ts/ts_m2gui/pull/17

            Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Please help to review the PR: https://github.com/lsst-ts/ts_m2gui/pull/17 Thanks!
            ttsai Te-Wei Tsai made changes -
            Reviewers Petr Kubanek [ pkubanek ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            ttsai Te-Wei Tsai added a comment -

            Thanks Petr's review in GitHub!

            Show
            ttsai Te-Wei Tsai added a comment - Thanks Petr's review in GitHub!
            ttsai Te-Wei Tsai made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            ttsai Te-Wei Tsai made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            ttsai Te-Wei Tsai made changes -
            Link This issue is triggering DM-35952 [ DM-35952 ]
            aclements Andy Clements made changes -
            Epic Link DM-27720 [ 442125 ] DM-27721 [ 442128 ]

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              Petr Kubanek
              Watchers:
              Petr Kubanek, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.