Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:
-
Story Points:0
-
Sprint:TSSW Sprint - Aug 15 - Aug 29
-
Team:Telescope and Site
-
Urgent?:No
Description
Improve stream_as_generator as follows:
- Simplify the code to use run_in_executor instead of being clever. This also makes it compatible with Windows, though that only matters when one copies the code for use elsewhere.
- Do not return empty strings.
- Add a new exit_str argument.
- Remove the encoding argument. No existing code was using it, and it's not compatible with the new technique for reading streams.
Pull request: https://github.com/lsst-ts/ts_salobj/pull/247