Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35909

Improve ts_salobj stream_as_generator

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Improve stream_as_generator as follows:

      • Simplify the code to use run_in_executor instead of being clever. This also makes it compatible with Windows, though that only matters when one copies the code for use elsewhere.
      • Do not return empty strings.
      • Add a new exit_str argument.
      • Remove the encoding argument. No existing code was using it, and it's not compatible with the new technique for reading streams.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          rowen Russell Owen created issue -
          rowen Russell Owen made changes -
          Field Original Value New Value
          Status To Do [ 10001 ] In Progress [ 3 ]
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Pull request: https://github.com/lsst-ts/ts_salobj/pull/247

          Show
          rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_salobj/pull/247
          rowen Russell Owen made changes -
          Summary Improve stream_as_generator to be compatible with Windows Improve ts_salobj stream_as_generator
          rowen Russell Owen made changes -
          Description Improve stream_as_generator to be compatible with Windows. This also simplifies the code.

          Note that salobj itself is necessarily compatible, but the code is sometimes copied to other projects.

          Also make other refinements:
          * Do not return empty strings.
          * Add a new exit_str argument.
          * Remove the encoding argument. No existing code was using it, and it's not compatible with the new technique for reading streams.           		Improve stream_as_generator as follows:

          * Simplify the code to use run_in_executor instead of being clever. This also makes it compatible with Windows, though that only matters when one copies the code for use elsewhere.
          * Do not return empty strings.
          * Add a new exit_str argument.
          * Remove the encoding argument. No existing code was using it, and it's not compatible with the new technique for reading streams.
          rowen Russell Owen made changes -
          Reviewers Eric Coughlin [ ecoughlin ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          Hide
          Permalink
          ecoughlin Eric Coughlin added a comment -

          Reviewed in GitHub.

          Show
          ecoughlin Eric Coughlin added a comment - Reviewed in GitHub.
          ecoughlin Eric Coughlin made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          rowen Russell Owen made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Merged to develop. I'll hold off on release for a bit to see if anything else is wanted.

          Show
          rowen Russell Owen added a comment - Merged to develop. I'll hold off on release for a bit to see if anything else is wanted.
          aclements Andy Clements made changes -
          Epic Link DM-27720 [ 442125 ] DM-27721 [ 442128 ]

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Eric Coughlin
            Watchers:
            Eric Coughlin, Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.