Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:
-
Story Points:0
-
Sprint:TSSW Sprint - Aug 15 - Aug 29
-
Team:Telescope and Site
-
Urgent?:No
Description
Improve stream_as_generator as follows:
- Simplify the code to use run_in_executor instead of being clever. This also makes it compatible with Windows, though that only matters when one copies the code for use elsewhere.
- Do not return empty strings.
- Add a new exit_str argument.
- Remove the encoding argument. No existing code was using it, and it's not compatible with the new technique for reading streams.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Summary | Improve stream_as_generator to be compatible with Windows | Improve ts_salobj stream_as_generator |
| Description |
Improve stream_as_generator to be compatible with Windows. This also simplifies the code.
Note that salobj itself is necessarily compatible, but the code is sometimes copied to other projects. Also make other refinements: * Do not return empty strings. * Add a new exit_str argument. * Remove the encoding argument. No existing code was using it, and it's not compatible with the new technique for reading streams. |
Improve stream_as_generator as follows:
* Simplify the code to use run_in_executor instead of being clever. This also makes it compatible with Windows, though that only matters when one copies the code for use elsewhere. * Do not return empty strings. * Add a new exit_str argument. * Remove the encoding argument. No existing code was using it, and it's not compatible with the new technique for reading streams. |
| Reviewers | Eric Coughlin [ ecoughlin ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Eric Coughlin
made changes -
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |