Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-35909

Improve ts_salobj stream_as_generator

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None

    Description

      Improve stream_as_generator as follows:

      • Simplify the code to use run_in_executor instead of being clever. This also makes it compatible with Windows, though that only matters when one copies the code for use elsewhere.
      • Do not return empty strings.
      • Add a new exit_str argument.
      • Remove the encoding argument. No existing code was using it, and it's not compatible with the new technique for reading streams.

      Attachments

        Activity

          rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_salobj/pull/247

          Reviewed in GitHub.

          ecoughlin Eric Coughlin added a comment - Reviewed in GitHub.
          rowen Russell Owen added a comment -

          Merged to develop. I'll hold off on release for a bit to see if anything else is wanted.

          rowen Russell Owen added a comment - Merged to develop. I'll hold off on release for a bit to see if anything else is wanted.

          People

            rowen Russell Owen
            rowen Russell Owen
            Eric Coughlin
            Eric Coughlin, Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.