Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36001

Fix missed events callback for events fired from high (telemetry) traffic CSC

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      When CSC produces high-speed (M1M3 telemetry) data, receiving code (using ts_salobj remote) doesn't fire a callback for (all?) received events.

      This is most likely caused by discarding events in sal_info. The problem started with 96830f2a39e789d9d4d48b1f9f173e22fdb95d10 commit into ts_salinfo.

        Attachments

          Activity

          Hide
          pkubanek Petr Kubanek added a comment -
          Show
          pkubanek Petr Kubanek added a comment - Please see PR: https://github.com/lsst-ts/ts_salobj/pull/249
          Hide
          pkubanek Petr Kubanek added a comment -

          The problem was that if multiple topic changes would return, only the first one will be processed - see return in _blocking_read, which cuts processing further topics. As _blocking_read is executed in executor, processing shall be done outside of the executed loop. So instead of returning single reader/data instance, an array of tuples (reader, data) is returned and then processed.

          Show
          pkubanek Petr Kubanek added a comment - The problem was that if multiple topic changes would return, only the first one will be processed - see return in _blocking_read, which cuts processing further topics. As _blocking_read is executed in executor, processing shall be done outside of the executed loop. So instead of returning single reader/data instance, an array of tuples (reader, data) is returned and then processed.
          Hide
          rowen Russell Owen added a comment -

          Reviewed on github. Thank you very much for finding and fixing this issue.

          Show
          rowen Russell Owen added a comment - Reviewed on github. Thank you very much for finding and fixing this issue.

            People

            Assignee:
            pkubanek Petr Kubanek
            Reporter:
            pkubanek Petr Kubanek
            Reviewers:
            Russell Owen
            Watchers:
            Dave Mills, Petr Kubanek, Russell Owen, Tiago Ribeiro, Wouter van Reeven
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.