Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36044

Migrate the LabVIEW Functions from M2 Server to M2 Cell

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_main_telescope
    • Labels:
    • Story Points:
      2
    • Epic Link:
    • Sprint:
      TSSW Sprint - Aug 29 - Sep 12
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Migrate the LabVIEW functions from M2 server (ts_mtm2) to M2 cell (ts_mtm2_cell). This ticket will take time to understand the M2 cell LabVIEW code as well.

      Patricio has the documentation here: M2 Cell Code Documentation.

        Attachments

          Issue Links

          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-36063 Fix the Unsupported Dialog Error in Real-Time Controller

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            ttsai Te-Wei Tsai created issue -
            ttsai Te-Wei Tsai made changes -
            Field Original Value New Value
            Description Migrate the LabVIEW functions from M2 server to M2 cell. This ticket will take time to understand the M2 cell LabVIEW code as well. Migrate the LabVIEW functions from M2 server (*ts_mtm2*) to M2 cell (*ts_mtm2_cell*). This ticket will take time to understand the M2 cell LabVIEW code as well.
            ttsai Te-Wei Tsai made changes -
            Description Migrate the LabVIEW functions from M2 server (*ts_mtm2*) to M2 cell (*ts_mtm2_cell*). This ticket will take time to understand the M2 cell LabVIEW code as well. Migrate the LabVIEW functions from M2 server (*ts_mtm2*) to M2 cell (*ts_mtm2_cell*). This ticket will take time to understand the M2 cell LabVIEW code as well.

            Patricio has the documentation here: [M2 Cell Code Documentation|https://confluence.lsstcorp.org/display/LTS/M2+Cell+Code+Documentation].
            ttsai Te-Wei Tsai made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            ttsai Te-Wei Tsai made changes -
            Story Points 1
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment - - edited

            The main code needs to update is the NetworkInterface.vi. Before this, needs to update the code to let the cell code can read the configuration files. There is no message in STM to tell a command is done or not. I may need to do this part by myself.

            It looks like I need to do all the user event for the TcpIpInterface in ts_mtm2. Otherwise, I can not copy this module directly.

            It looks like I need to redo all the error code checking in the ts_mtm2 as well. The ts_mtm2_cell does not have this.

            Show
            ttsai Te-Wei Tsai added a comment - - edited The main code needs to update is the NetworkInterface.vi . Before this, needs to update the code to let the cell code can read the configuration files. There is no message in STM to tell a command is done or not. I may need to do this part by myself. It looks like I need to do all the user event for the TcpIpInterface in ts_mtm2. Otherwise, I can not copy this module directly. It looks like I need to redo all the error code checking in the ts_mtm2 as well. The ts_mtm2_cell does not have this.
            ttsai Te-Wei Tsai made changes -
            Attachment targetSpecificError.png [ 63257 ]
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment - - edited

            I got the target specific error as the following:

            A similar discussion is here:
            https://forums.ni.com/t5/LabVIEW/Error-Details-Display-Dialog-vi-and-Not-Found-Dialog-vi/td-p/4062026

            Issue the DM-36063 to fix this.

            Show
            ttsai Te-Wei Tsai added a comment - - edited I got the target specific error as the following: A similar discussion is here: https://forums.ni.com/t5/LabVIEW/Error-Details-Display-Dialog-vi-and-Not-Found-Dialog-vi/td-p/4062026 Issue the DM-36063 to fix this.
            ttsai Te-Wei Tsai made changes -
            Link This issue is triggering DM-36063 [ DM-36063 ]
            ttsai Te-Wei Tsai made changes -
            Story Points 1 2
            ttsai Te-Wei Tsai made changes -
            Attachment weirdSavement.png [ 63266 ]
            ttsai Te-Wei Tsai made changes -
            Attachment weirdSavement.png [ 63266 ]
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            I realized it is not easy to copy the LabVIEW code if there is the bad dependency. If people put the typedef into the library, this will make the duplication difficult. In many times, I need to disconnect the typedef from the library in ts_mtm2.

            Show
            ttsai Te-Wei Tsai added a comment - I realized it is not easy to copy the LabVIEW code if there is the bad dependency. If people put the typedef into the library, this will make the duplication difficult. In many times, I need to disconnect the typedef from the library in ts_mtm2 .
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Please help to review the PR:
            https://github.com/lsst-ts/ts_mtm2_cell/pull/5

            This PR is just to copy the code from the ts_mtm2. Only the final commit is meaning in this PR. You could see the comments in this ticket to know the condition as well.

            Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Please help to review the PR: https://github.com/lsst-ts/ts_mtm2_cell/pull/5 This PR is just to copy the code from the ts_mtm2. Only the final commit is meaning in this PR. You could see the comments in this ticket to know the condition as well. Thanks!
            ttsai Te-Wei Tsai made changes -
            Reviewers Patricio Cortes [ pcortes ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            pcortes Patricio Cortes added a comment -

            PR approved!

            Show
            pcortes Patricio Cortes added a comment - PR approved!
            ttsai Te-Wei Tsai made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            ttsai Te-Wei Tsai made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              Patricio Cortes
              Watchers:
              Patricio Cortes, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.