Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36072

Fix ReadTopic.aget to not take data from next

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Sprint:
      TSSW Sprint - Aug 29 - Sep 12
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      In working on the confluent_kafka version of ts_salobj I found a few issues that I want to back-port to DDS salobj, including:

      • ReadTopic.aget may steal a value from the next, despite documentation to the contrary.
      • BaseCscTestCase.make_csc has a race condition in how it creates the remote and CSC
      • A few tests have race conditions.
      • test_command_isolation in test_topics does not work as advertised, and the advertised behavior makes for a better test.

      Note that the race conditions probably have not been causing any problems, but it's safest to fix them in any case.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -
            Show
            rowen Russell Owen added a comment - Pull requests: https://github.com/lsst-ts/ts_salobj/pull/250
            Hide
            wvreeven Wouter van Reeven added a comment -

            Reviewed on GitHub.

            Show
            wvreeven Wouter van Reeven added a comment - Reviewed on GitHub.
            Hide
            rowen Russell Owen added a comment -

            Tagged v7.1.4

            Show
            rowen Russell Owen added a comment - Tagged v7.1.4

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Wouter van Reeven
              Watchers:
              Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.