Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36097

Continue implementing LOVE REST support

    XMLWordPrintable

    Details

      Description

      Things left from DM-36035:

      • Handle failure to set the auth list in CSCs such that feedback can be sent to the REST server if that's used.
      • Add sending feedback to the REST server regarding setting the auth list in CSCs.
      • Once the RestAuthorizeHandler has been implemented, integrate it into the Authorize CSC.
      • Add tests for the REST handler with a leading "-" and some with no prefix.
      • Add a test utility that provides a sequence of valid auth request data, with the expected result (authorized users and non-authorized CSCs) on success.

      This ticket is for doing all that.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-36035 Start implementing LOVE REST support

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            Made sure that information about the CSCs for which setting authList failed and for which succeeded is stored in variables so that can be handled by the calling code. Added handling code as well.

            Show
            wvreeven Wouter van Reeven added a comment - Made sure that information about the CSCs for which setting authList failed and for which succeeded is stored in variables so that can be handled by the calling code. Added handling code as well.
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment - - edited

            I am not completely satisfied with the way the RestAuthorizeHandler handles the response of the REST server after sending the results of processing the auth requests (which contact the involved CSCs). I am looking forward to hear what you think about the current implementation.

            ts_config_ocs PR: https://github.com/lsst-ts/ts_config_ocs/pull/107

            ts_authorize PR: https://github.com/lsst-ts/ts_authorize/pull/12

            Show
            wvreeven Wouter van Reeven added a comment - - edited I am not completely satisfied with the way the RestAuthorizeHandler handles the response of the REST server after sending the results of processing the auth requests (which contact the involved CSCs). I am looking forward to hear what you think about the current implementation. ts_config_ocs PR: https://github.com/lsst-ts/ts_config_ocs/pull/107 ts_authorize PR: https://github.com/lsst-ts/ts_authorize/pull/12
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Reviewed on github

            Show
            rowen Russell Owen added a comment - Reviewed on github

              People

              Assignee:
              wvreeven Wouter van Reeven
              Reporter:
              wvreeven Wouter van Reeven
              Reviewers:
              Russell Owen
              Watchers:
              Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.