Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: daf_butler
-
Labels:
-
Story Points:8
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
This ticket is a spin-off for a number of changes to registry support classes originally done on the branch for DM-31725; these are either prerequisites for the main work there or pre-existing problems identified while doing the work. None of these involve the upcoming daf_relation package, approval of RFC-878 or RFC-879, or Python 3.10. Some may seem of neutral value without the context of the main DM-31725 changes (and I'll try to motivate them on the PR where I haven't already done so in code comments).
Attachments
Issue Links
Activity
Looks good, few comments on PR. Codecov finds few cases for overlaps() with a single Time parameter, which is not covered by existing tests, and also new temporary_table decorator has no unit test.
Comments addressed, and I've added the tests whose absence you spotted (thanks!) so now codecov is green. Just waiting on Jenkins now.
Andy Salnikov, I'm putting this back in review because I've made nontrivial changes to one commit and added a few more; see the latest comment on the PR.
Looks good.
Andy Salnikov, here's areview back to you. No rush since I'm out next week. It's all miscellaneous things and definitely better to look at one commit at a time. Hopefully the commit messages will help explain what's going on.
https://github.com/lsst/daf_butler/pull/731
Codecov is slightly unhappy and I haven't looked in detail to see if I missed something genuinely worth testing or if it's just complaining about a bunch of abstract methods raising NotImplementedError; if you see something, let me know, but I also plan to take a closer look for missing tests myself when I get back.