Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_aos
-
Labels:None
-
Team:Telescope and Site
Description
Currently the AOS Algorithm for wavefront estimation has several convergence criteria that stop the estimation of the wavefront errors from defocal images.
We stop calculation if:
- the change to the next Zernike estimation is less than the tolerance level https://github.com/lsst-ts/ts_wep/blob/7409c05e1e9ba236f3a3e8bfb8b503246ca5d72a/python/lsst/ts/wep/cwfs/Algorithm.py#L797
- a caustic is reached https://github.com/lsst-ts/ts_wep/blob/7409c05e1e9ba236f3a3e8bfb8b503246ca5d72a/python/lsst/ts/wep/cwfs/Algorithm.py#L753
However, this information is not persisted through to `wfEstimator` that only obtains from Algorightm the Zernike values https://github.com/lsst-ts/ts_wep/blob/7409c05e1e9ba236f3a3e8bfb8b503246ca5d72a/python/lsst/ts/wep/WfEstimator.py#L253
This ticket is to modify parts of `ts_wep` (eg. `Algorithm`, `wfEstimator`, `EstimateZernikesBase`, `calcZernikes`) so that the information on how convergence was met would be preserved each time the algorithm is run.
Attachments
Issue Links
Activity
Edited the ticket since it is contained by a larger logging effort by JFC.
Was reviewed extensively by Krzysztof Suberlak, Bryce Kalmbach, and Te-Wei Tsai on Github: https://github.com/lsst-ts/ts_wep/pull/152
John Franklin Crenshaw
added a comment - Was reviewed extensively by Krzysztof Suberlak , Bryce Kalmbach , and Te-Wei Tsai on Github: https://github.com/lsst-ts/ts_wep/pull/152 
It might be good to have a balance between the log level and debug details.