Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36148

Fix a memory leak and improve handling of invalid values from the Astelco DIMM

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Fix a memory leak in ts_dimm: AstelcoDIMM is accumulating command info in running_commands instead of purging done commands. This is exacerbated by the fact that status_loop is sending command far too often.

      Improve the handling of invalid data from the Astelco DIMM. There are two issues.

      • There are a number of values that mean "could not determine the value". One of those is LOCKEDBY, which we were seeing shortly after setting the mode. Handle that and all other error codes.
      • A string variable with unknown value can be NULL (no double quotes) if unknown; handle that properly.

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment -
          Show
          rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_dimm/pull/27
          Hide
          tribeiro Tiago Ribeiro added a comment -

          PR reviewed in GH...

          Show
          tribeiro Tiago Ribeiro added a comment - PR reviewed in GH...
          Hide
          rowen Russell Owen added a comment - - edited

          Merged to develop and main and tagged v0.8.1

          Show
          rowen Russell Owen added a comment - - edited Merged to develop and main and tagged v0.8.1

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Tiago Ribeiro
            Watchers:
            Russell Owen, Tiago Ribeiro
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.