Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ip_isr
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Team:Data Release Production
Description
The overscan timing is still enabled in ip_isr, although it is not particularly useful anymore. This ticket will remove those messages as all methods run in approximately the same short time.
Attachments
Activity
I don't think that this message is useful anymore, even at the debug level. The improved MEDIAN_PER_ROW code makes that algorithm comparable in speed to the other methods, so I think this is just noise now.
Looks good to me. If the performance is already comparable in time to other methods, I agree it's not needed anymore.
To reiterate what I mentioned on slack: We have an API for timing blocks of code: lsst.utils.timer.time_this – using that would put the timing messages into a timer.lsst logger at DEBUG level and so would hide them in normal usage but still allow them to be enabled if timing information is needed.