Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: fgcmcal
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
The release of matplotlib 3.6.0 has a bug in hexbin when log scaling is used and there are no valid values (https://github.com/matplotlib/matplotlib/issues/23922). We pinned matplotlib with DM-36267, but we can also update fgcm to not try to make these plots. (Note that this matplotlib bug is planned to be fixed for the 3.6.1 release). Thus, this is the belt-and-suspenders approach.
I made a few minor comments on the fgcm code (stupidly not on the PR at first, but I tried to transfer the spirit of the discussion there). With a clean Jenkins, LGTM!