[DM-3633] Add readMatches back to meas_astrom - Jira

Russell Owen created issue - 28/Aug/15 2:53 PM

Russell Owen made changes - 28/Aug/15 2:54 PM

Field	Original Value	New Value
Description	Recent changes to meas_astrom accidentally removed a function readMatches (copied below). Please restore it, preferably in its own module (though if someday we have more small python functions we may want a utils.py module). {code} def readMatches(butler, dataId, sourcesName='icSrc', matchesName='icMatch', config=MeasAstromConfig(), sourcesFlags=afwTable.SOURCE_IO_NO_FOOTPRINTS): """Read matches, sources and catalogue; combine. @param butler Data butler @param dataId Data identifier for butler @param sourcesName Name for sources from butler @param matchesName Name for matches from butler @param sourcesFlags Flags to pass for source retrieval @returns Matches """ sources = butler.get(sourcesName, dataId, flags=sourcesFlags) packedMatches = butler.get(matchesName, dataId) astrom = Astrometry(config) return astrom.joinMatchListWithCatalog(packedMatches, sources) {code}	Recent changes to meas_astrom accidentally removed a function readMatches (copied below). Please restore it, preferably in its own module (though if someday we have more small python functions we may want a utils.py module). {code} def readMatches(butler, dataId, sourcesName='icSrc', matchesName='icMatch', config=MeasAstromConfig(), sourcesFlags=afwTable.SOURCE_IO_NO_FOOTPRINTS): """Read matches, sources and catalogue; combine. @param butler Data butler @param dataId Data identifier for butler @param sourcesName Name for sources from butler @param matchesName Name for matches from butler @param sourcesFlags Flags to pass for source retrieval @returns Matches """ sources = butler.get(sourcesName, dataId, flags=sourcesFlags) packedMatches = butler.get(matchesName, dataId) astrom = Astrometry(config) return astrom.joinMatchListWithCatalog(packedMatches, sources) {code} Also include a unit test.

Russell Owen made changes - 28/Aug/15 2:54 PM

Story Points

1

2

Russell Owen made changes - 28/Aug/15 2:55 PM

Description

Recent changes to meas_astrom accidentally removed a function readMatches (copied below). Please restore it, preferably in its own module (though if someday we have more small python functions we may want a utils.py module).
{code}
def readMatches(butler, dataId, sourcesName='icSrc', matchesName='icMatch', config=MeasAstromConfig(), sourcesFlags=afwTable.SOURCE_IO_NO_FOOTPRINTS):
    """Read matches, sources and catalogue; combine.
    @param butler Data butler
    @param dataId Data identifier for butler
    @param sourcesName Name for sources from butler
    @param matchesName Name for matches from butler
    @param sourcesFlags Flags to pass for source retrieval
    @returns Matches
    """
    sources = butler.get(sourcesName, dataId, flags=sourcesFlags)
    packedMatches = butler.get(matchesName, dataId)
    astrom = Astrometry(config)
    return astrom.joinMatchListWithCatalog(packedMatches, sources)
{code}

Also include a unit test.

Recent changes to meas_astrom accidentally removed a function readMatches (copied below). Please restore it, preferably in its own module (though if someday we have more small python functions we may want a utils.py module).

Also please include a unit test.

{code}
def readMatches(butler, dataId, sourcesName='icSrc', matchesName='icMatch', config=MeasAstromConfig(), sourcesFlags=afwTable.SOURCE_IO_NO_FOOTPRINTS):
    """Read matches, sources and catalogue; combine.
    @param butler Data butler
    @param dataId Data identifier for butler
    @param sourcesName Name for sources from butler
    @param matchesName Name for matches from butler
    @param sourcesFlags Flags to pass for source retrieval
    @returns Matches
    """
    sources = butler.get(sourcesName, dataId, flags=sourcesFlags)
    packedMatches = butler.get(matchesName, dataId)
    astrom = Astrometry(config)
    return astrom.joinMatchListWithCatalog(packedMatches, sources)
{code}

Lauren MacArthur made changes - 02/Dec/15 1:20 PM

Assignee

Lauren MacArthur [ lauren ]

Lauren MacArthur made changes - 02/Dec/15 4:27 PM

Status

To Do [ 10001 ]

In Progress [ 3 ]

John Swinbank made changes - 04/Dec/15 6:23 AM

Epic Link

~~DM-3585~~ [ 19682 ]

John Swinbank made changes - 04/Dec/15 6:23 AM

Sprint		Science Pipelines DM-W16-4 [ 187 ]
Story Points	2	4
Team		Data Release Production [ 10301 ]

Lauren MacArthur made changes - 18/Dec/15 12:22 PM

Reviewers		Russell Owen [ rowen ]
Status	In Progress [ 3 ]	In Review [ 10004 ]

Russell Owen made changes - 18/Dec/15 3:37 PM

Status

In Review [ 10004 ]

Reviewed [ 10101 ]

Lauren MacArthur made changes - 18/Dec/15 4:55 PM

Resolution		Done [ 10000 ]
Status	Reviewed [ 10101 ]	Done [ 10002 ]

Lauren MacArthur made changes - 23/Dec/15 3:34 PM

Remote Link