Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3633

Add readMatches back to meas_astrom

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom
    • Labels:
      None

      Description

      Recent changes to meas_astrom accidentally removed a function readMatches (copied below). Please restore it, preferably in its own module (though if someday we have more small python functions we may want a utils.py module).

      Also please include a unit test.

      def readMatches(butler, dataId, sourcesName='icSrc', matchesName='icMatch', config=MeasAstromConfig(), sourcesFlags=afwTable.SOURCE_IO_NO_FOOTPRINTS):
          """Read matches, sources and catalogue; combine.
          @param butler Data butler
          @param dataId Data identifier for butler
          @param sourcesName Name for sources from butler
          @param matchesName Name for matches from butler
          @param sourcesFlags Flags to pass for source retrieval
          @returns Matches
          """
          sources = butler.get(sourcesName, dataId, flags=sourcesFlags)
          packedMatches = butler.get(matchesName, dataId)
          astrom = Astrometry(config)
          return astrom.joinMatchListWithCatalog(packedMatches, sources)
      

        Attachments

          Issue Links

            Activity

            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Description Recent changes to meas_astrom accidentally removed a function readMatches (copied below). Please restore it, preferably in its own module (though if someday we have more small python functions we may want a utils.py module).
            {code}
            def readMatches(butler, dataId, sourcesName='icSrc', matchesName='icMatch', config=MeasAstromConfig(), sourcesFlags=afwTable.SOURCE_IO_NO_FOOTPRINTS):
                """Read matches, sources and catalogue; combine.
                @param butler Data butler
                @param dataId Data identifier for butler
                @param sourcesName Name for sources from butler
                @param matchesName Name for matches from butler
                @param sourcesFlags Flags to pass for source retrieval
                @returns Matches
                """
                sources = butler.get(sourcesName, dataId, flags=sourcesFlags)
                packedMatches = butler.get(matchesName, dataId)
                astrom = Astrometry(config)
                return astrom.joinMatchListWithCatalog(packedMatches, sources)
            {code}
            Recent changes to meas_astrom accidentally removed a function readMatches (copied below). Please restore it, preferably in its own module (though if someday we have more small python functions we may want a utils.py module).
            {code}
            def readMatches(butler, dataId, sourcesName='icSrc', matchesName='icMatch', config=MeasAstromConfig(), sourcesFlags=afwTable.SOURCE_IO_NO_FOOTPRINTS):
                """Read matches, sources and catalogue; combine.
                @param butler Data butler
                @param dataId Data identifier for butler
                @param sourcesName Name for sources from butler
                @param matchesName Name for matches from butler
                @param sourcesFlags Flags to pass for source retrieval
                @returns Matches
                """
                sources = butler.get(sourcesName, dataId, flags=sourcesFlags)
                packedMatches = butler.get(matchesName, dataId)
                astrom = Astrometry(config)
                return astrom.joinMatchListWithCatalog(packedMatches, sources)
            {code}

            Also include a unit test.
            rowen Russell Owen made changes -
            Story Points 1 2
            rowen Russell Owen made changes -
            Description Recent changes to meas_astrom accidentally removed a function readMatches (copied below). Please restore it, preferably in its own module (though if someday we have more small python functions we may want a utils.py module).
            {code}
            def readMatches(butler, dataId, sourcesName='icSrc', matchesName='icMatch', config=MeasAstromConfig(), sourcesFlags=afwTable.SOURCE_IO_NO_FOOTPRINTS):
                """Read matches, sources and catalogue; combine.
                @param butler Data butler
                @param dataId Data identifier for butler
                @param sourcesName Name for sources from butler
                @param matchesName Name for matches from butler
                @param sourcesFlags Flags to pass for source retrieval
                @returns Matches
                """
                sources = butler.get(sourcesName, dataId, flags=sourcesFlags)
                packedMatches = butler.get(matchesName, dataId)
                astrom = Astrometry(config)
                return astrom.joinMatchListWithCatalog(packedMatches, sources)
            {code}

            Also include a unit test.
            Recent changes to meas_astrom accidentally removed a function readMatches (copied below). Please restore it, preferably in its own module (though if someday we have more small python functions we may want a utils.py module).

            Also please include a unit test.

            {code}
            def readMatches(butler, dataId, sourcesName='icSrc', matchesName='icMatch', config=MeasAstromConfig(), sourcesFlags=afwTable.SOURCE_IO_NO_FOOTPRINTS):
                """Read matches, sources and catalogue; combine.
                @param butler Data butler
                @param dataId Data identifier for butler
                @param sourcesName Name for sources from butler
                @param matchesName Name for matches from butler
                @param sourcesFlags Flags to pass for source retrieval
                @returns Matches
                """
                sources = butler.get(sourcesName, dataId, flags=sourcesFlags)
                packedMatches = butler.get(matchesName, dataId)
                astrom = Astrometry(config)
                return astrom.joinMatchListWithCatalog(packedMatches, sources)
            {code}
            lauren Lauren MacArthur made changes -
            Assignee Lauren MacArthur [ lauren ]
            lauren Lauren MacArthur made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            swinbank John Swinbank made changes -
            Epic Link DM-3585 [ 19682 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-W16-4 [ 187 ]
            Story Points 2 4
            Team Data Release Production [ 10301 ]
            lauren Lauren MacArthur made changes -
            Reviewers Russell Owen [ rowen ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            rowen Russell Owen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            lauren Lauren MacArthur made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            lauren Lauren MacArthur made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            lauren Lauren MacArthur made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Link This issue blocks DM-4936 [ DM-4936 ]
            lauren Lauren MacArthur made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            lauren Lauren MacArthur made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            jbosch Jim Bosch made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            price Paul Price made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            lauren Lauren MacArthur made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            rearmstr Bob Armstrong made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            rowen Russell Owen made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            jbosch Jim Bosch made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            nlust Nate Lust made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            nlust Nate Lust made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            nlust Nate Lust made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            nlust Nate Lust made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            nlust Nate Lust made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            price Paul Price made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            pschella Pim Schellart [X] (Inactive) made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            lauren Lauren MacArthur made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            lauren Lauren MacArthur made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            nlust Nate Lust made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            jbosch Jim Bosch made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            jbosch Jim Bosch made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]
            swinbank John Swinbank made changes -
            Remote Link This issue links to "Page (Confluence)" [ 13300 ] This issue links to "Page (Confluence)" [ 13300 ]

              People

              Assignee:
              lauren Lauren MacArthur
              Reporter:
              rowen Russell Owen
              Reviewers:
              Russell Owen
              Watchers:
              John Swinbank, Lauren MacArthur, Paul Price, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: