Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3635

configDictField.py has code that relies on an undefined variable

    Details

    • Type: Bug
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pex_config
    • Labels:
      None
    • Templates:
    • Story Points:
      2
    • Team:
      Data Facility

      Description

      While taking a linter pass on pex_config I found that ConfigDict.__setitem__ in configDictField.py has some code that uses an undefined variable value. See the else clause in:

              if oldValue is None:            
                  if x == dtype:
                      self._dict[k] = dtype(__name=name, __at=at, __label=label)
                  else:
                      self._dict[k] = dtype(__name=name, __at=at, __label=label, **x._storage)
                  if setHistory:
                      self.history.append(("Added item at key %s"%k, at, label))
              else:
                  if value == dtype:
                      value = dtype()
                  oldValue.update(__at=at, __label=label, **value._storage)
                  if setHistory:
                      self.history.append(("Modified item at key %s"%k, at, label))
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              rowen Russell Owen
              Watchers:
              Jim Bosch, Paul Price, Russell Owen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel