Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36372

Two minor bugs in ip_isr deferredCharge.py

    XMLWordPrintable

Details

    • Bug
    • Status: Done
    • Resolution: Done
    • None
    • ip_isr
    • None
    • 2
    • External
    • No

    Description

      I've now succeeded in generating the CTI corrections for 3 CCDs from the BOT run 13144. With snyder18, we did the comparison below(CTI_Comparison.pdf) of the overscan analysis of CCD 11, comparing to Adam's original code. This seems to compare well, so that part of the code looks good.

      I tried applying the correction, but that is blocked by DM-36280. However, I was able to apply the correction in a notebook, and I discovered two bugs in deferredCharge.py. At this point in flipData, the two dictionary calls to X_FLIP and Y_FLIP should use square brackets, not parentheses:
      https://github.com/lsst/ip_isr/blob/564bce95634bcb13be2c8ab9beea4d036a4b12fd/python/lsst/ip/isr/deferredCharge.py#L627

      Also, at this point:

      https://github.com/lsst/ip_isr/blob/564bce95634bcb13be2c8ab9beea4d036a4b12fd/python/lsst/ip/isr/deferredCharge.py#L598

      I believe that

      image[amp.getBBox()].array[:, :] = correctedAmpData[:, :]
      

      should read:

      image[amp.getRawBBox()].array[:, :] = correctedAmpData[:, :]
      

      After making these changes, the code ran and applied the CTI correction. The results on two amps are shown in the attached CTI_Test_3021120700215_28Sep22.pdf. I still don't think this correction is right, and am working with Adam to understand, but at least it is now running end-to-end.

      Attachments

        Activity

          cslage Craig Lage created issue -
          czw Christopher Waters made changes -
          Field Original Value New Value
          Status To Do [ 10001 ] In Progress [ 3 ]
          czw Christopher Waters made changes -
          Resolution Done [ 10000 ]
          Status In Progress [ 3 ] Done [ 10002 ]
          czw Christopher Waters made changes -
          Epic Link DM-32163 [ 779863 ]
          Reviewers Christopher Waters [ cwaters ]
          Assignee Christopher Waters [ cwaters ] Craig Lage [ cslage ]
          czw Christopher Waters made changes -
          Story Points 2
          yusra Yusra AlSayyad made changes -
          Epic Link DM-32163 [ 779863 ]

          People

            cslage Craig Lage
            cslage Craig Lage
            Christopher Waters
            Adam Snyder, Craig Lage
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.