Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: cp_pipe
-
Labels:None
-
Story Points:4
-
Epic Link:
-
Team:Data Release Production
Description
If the sequencer file changes, then we expect that there will be a change in the quality that calibrations created for a previous sequencer will have when applied. This should be tracked in the files, and if there is a mismatch, we should warn about this.
Attachments
Activity
Added config options to handle if this should raise. New jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/38115/pipeline
I'm done with my part of the review. Quite a few comments but they're all very samey, and probably all stem from a basic misunderstanding on my part.
https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/38138/pipeline/ is the working Jenkins run. Are we all good on this, or does anyone want to do another iteration of PR comments?
Sorry for being slow, just left some replies to your replies on the PR. Do whatever you like with them though. The only bit I really wonder about is the debug level log, but maybe I'm reading the code/thinking about it wrong.
The code changes here only issues log warnings on sequencer mismatch, it does not raise.
Jenkins:
https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/38114/pipeline