Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36427

Add test for script runtime vs estimated duration

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_integration
    • Labels:
      None

      Description

      Patrick suggested that adding a test to compare the actual runtime of the script to the estimated duration of the script.

      Estimated duration is defined in each script as the metadata.duration attribute and published by the Script_logevent_metadata topic.

      Actual runtime can be calculated with different in the timestampProcessStart attribute of the ScriptQueue_logevent_script topic (as the start time) and the private_sndStamp attribute of the last Script_logevent_state event (as the end time) for the given script.

        Attachments

          Activity

          Show
          rbovill Rob Bovill added a comment - https://github.com/lsst-ts/robotframework_EFD/tree/tickets/DM-36427
          Hide
          rbovill Rob Bovill added a comment -

          The Common_Keywords.resource now imports the String and DateTime libraries.  Remove the explicit imports from all the test suites.

          Show
          rbovill Rob Bovill added a comment - The Common_Keywords.resource now imports the String and DateTime libraries.  Remove the explicit imports from all the test suites.
          Hide
          pingraham Patrick Ingraham added a comment -

          This is an example of where it gets set in a script. It's the `set_metadata` method.
          https://github.com/lsst-ts/ts_externalscripts/blob/develop/python/lsst/ts/externalscripts/auxtel/latiss_base_align.py#L677

          Show
          pingraham Patrick Ingraham added a comment - This is an example of where it gets set in a script. It's the `set_metadata` method. https://github.com/lsst-ts/ts_externalscripts/blob/develop/python/lsst/ts/externalscripts/auxtel/latiss_base_align.py#L677
          Show
          rbovill Rob Bovill added a comment - https://github.com/lsst-ts/robotframework_EFD/pull/24
          Hide
          rbovill Rob Bovill added a comment -

          Ready for review.

          Show
          rbovill Rob Bovill added a comment - Ready for review.
          Hide
          mareuter Michael Reuter added a comment -

          PR reviewed on GH

          Show
          mareuter Michael Reuter added a comment - PR reviewed on GH

            People

            Assignee:
            rbovill Rob Bovill
            Reporter:
            rbovill Rob Bovill
            Reviewers:
            Michael Reuter, Tiago Ribeiro
            Watchers:
            Michael Reuter, Patrick Ingraham, Rob Bovill, Tiago Ribeiro
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.