Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3649

Fix warnings in log test program

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: log
    • Labels:
      None
    • Team:
      Architecture

      Description

      The logTest.cc test in log issues compiler warnings concerning tmpnam. These should be fixed by using mkstemp.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-1052 Add / improve tests and examples for Log package

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            tmpnam() has been replaced by mkstemp()

            This also fixes a problem where the temporary file created in the parent/child test had not been removed.

            Show
            tjenness Tim Jenness added a comment - tmpnam() has been replaced by mkstemp() This also fixes a problem where the temporary file created in the parent/child test had not been removed.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            One minor problem; otherwise looks good to go.

            Show
            ktl Kian-Tat Lim added a comment - One minor problem; otherwise looks good to go.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I upped the buffer size to PATH_MAX and ensure that a "/" is included. Now merged.

            Show
            tjenness Tim Jenness added a comment - I upped the buffer size to PATH_MAX and ensure that a "/" is included. Now merged.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Kian-Tat Lim
              Watchers:
              Kian-Tat Lim, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: