Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36571

Remove applyColorTerms=None option from PhotoCalTask and default to False

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP F22-5 (October)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Remove the None option from PhotoCalConfig.applyColorTerms, and change its default to False. I did a cursory search of our packages, and I don't think we will need to change anything outside of pipe_tasks, but I won't know for sure until I make the change.

      We don't have any system for deprecating a single value of a ChoiceField; I don't know if we actually need that here, since I think all our supported pipelines/instruments override it to True or False as necessary.

      This is the implementation ticket for RFC-883.

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-883 Remove applyColorTerms=None option from PhotoCalTask

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37471/pipeline

            Show
            Parejkoj John Parejko added a comment - Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37471/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Lee Kelvin: I believe this implements the RFC as written, and I added some tweaks to the existing doc fields as well.

            Show
            Parejkoj John Parejko added a comment - Lee Kelvin : I believe this implements the RFC as written, and I added some tweaks to the existing doc fields as well.
            Hide
            Permalink
            lskelvin Lee Kelvin added a comment -

            Thanks for implementing this John. This looks good to me. A few minor doc-string comments on the PR, but otherwise good. As Jenkins is happy, I think this is good to merge - cheers.

            Show
            lskelvin Lee Kelvin added a comment - Thanks for implementing this John. This looks good to me. A few minor doc-string comments on the PR, but otherwise good. As Jenkins is happy, I think this is good to merge - cheers.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Jenkins run with ci_hsc: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37536/pipeline

            Show
            Parejkoj John Parejko added a comment - Jenkins run with ci_hsc: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37536/pipeline

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Lee Kelvin
              Watchers:
              Ian Sullivan, Jim Bosch, John Parejko, Lee Kelvin, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.