Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36638

Add snap combination as a subtask at the beginning of CalibrateImageTask

    XMLWordPrintable

Details

    Description

      If the survey decides to use image snaps, then those will need to be combined in the task that immediately follows ISR.

      See RFC-918 for the discussion that led to this location as the right place.

      Attachments

        Issue Links

          Activity

            Parejkoj John Parejko added a comment - - edited

            For reference, here are the commands I ran to find a 2-snap visit from LATISS on /repo/embargo:

            To identify all visit_system=2 science exposures, you need to use query-data-ids and include visit in the dimensions query:

            butler query-data-ids --where "instrument='LATISS' and visit_system=2" /repo/embargo exposure,visit
            

            Given such a list of visits and exposures, this confirms that a given visit has two exposures:

            butler query-data-ids --where "instrument='LATISS' and visit=2022102700746" /repo/embargo exposure
            

            Parejkoj John Parejko added a comment - - edited For reference, here are the commands I ran to find a 2-snap visit from LATISS on /repo/embargo : To identify all visit_system=2 science exposures, you need to use query-data-ids and include visit in the dimensions query: butler query-data-ids --where "instrument='LATISS' and visit_system=2" /repo/embargo exposure,visit Given such a list of visits and exposures, this confirms that a given visit has two exposures: butler query-data-ids --where "instrument='LATISS' and visit=2022102700746" /repo/embargo exposure
            Parejkoj John Parejko added a comment - Jenkins run: https://rubin-ci.slac.stanford.edu/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/713/pipeline
            Parejkoj John Parejko added a comment -

            mfisherlevine: Are you available to review this medium-sized ticket? The LATISS config for CalibrateImage is directly relevant to you (will let you test out CalibrateImage with minimal friction), while the pipe_tasks change is mostly code removal (cleaning up SnapCombine so that any feature we add in the future don't have to deal with existing configs and code).

            PRs:

            Parejkoj John Parejko added a comment - mfisherlevine : Are you available to review this medium-sized ticket? The LATISS config for CalibrateImage is directly relevant to you (will let you test out CalibrateImage with minimal friction), while the pipe_tasks change is mostly code removal (cleaning up SnapCombine so that any feature we add in the future don't have to deal with existing configs and code). PRs: https://github.com/lsst/pipe_tasks/pull/864 https://github.com/lsst/meas_base/pull/259 https://github.com/lsst/obs_lsst/pull/486 (adding LATISS config for CalibrateImage)

            Right now, honestly, not really, sorry. I've just come back from vacation, and am totally overwhelmed with the amount of things I need to do to catch up, let alone deliver aside from the catch-up. Anyone else you could ask for this, do you think?

            mfisherlevine Merlin Fisher-Levine added a comment - Right now, honestly, not really, sorry. I've just come back from vacation, and am totally overwhelmed with the amount of things I need to do to catch up, let alone deliver aside from the catch-up. Anyone else you could ask for this, do you think?

            kherner: thanks for taking the review. See above for the PRs and other comments.

            Parejkoj John Parejko added a comment - kherner : thanks for taking the review. See above for the PRs and other comments.

            People

              Parejkoj John Parejko
              czw Christopher Waters
              Kenneth Herner
              Christopher Waters, Ian Sullivan, Jim Bosch, John Parejko, Merlin Fisher-Levine
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.