Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3669

Please remove chat about "EUPS integration" with -Q

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: sconsUtils
    • Labels:
      None
    • Team:
      Architecture

      Description

      When you added messages about "EUPS integration" you failed to make the message generation obey -Q (cf. DM-1565). Please fix this.

        Attachments

          Issue Links

            Activity

            Hide
            jhoblitt Joshua Hoblitt added a comment -

            Robert Lupton Did you intend to assign this issue to Tim Jenness ?

            Show
            jhoblitt Joshua Hoblitt added a comment - Robert Lupton Did you intend to assign this issue to Tim Jenness ?
            Hide
            rhl Robert Lupton added a comment -

            No, I didn't as it's your bug; introduced in 4c6e0c32.

            Show
            rhl Robert Lupton added a comment - No, I didn't as it's your bug; introduced in 4c6e0c32.
            Hide
            tjenness Tim Jenness added a comment -

            Robert Lupton I've pushed a fix to the ticket branch. It's a single line change and I'm not sure it needs formal reviewing as such but I'll let you decide that.

            Show
            tjenness Tim Jenness added a comment - Robert Lupton I've pushed a fix to the ticket branch. It's a single line change and I'm not sure it needs formal reviewing as such but I'll let you decide that.
            Hide
            rhl Robert Lupton added a comment -

            Looks good, thanks.

            I think this would probably fall into the category of "trivial no need for review", but that's not my call.

            Show
            rhl Robert Lupton added a comment - Looks good, thanks. I think this would probably fall into the category of "trivial no need for review", but that's not my call.
            Hide
            tjenness Tim Jenness added a comment -

            Merged.

            Show
            tjenness Tim Jenness added a comment - Merged.
            Hide
            ktl Kian-Tat Lim added a comment -

            For future reference, I concur that this is small enough that it didn't require peer review.

            Show
            ktl Kian-Tat Lim added a comment - For future reference, I concur that this is small enough that it didn't require peer review.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                rhl Robert Lupton
                Reviewers:
                Robert Lupton
                Watchers:
                Joshua Hoblitt, Kian-Tat Lim, Robert Lupton, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel