Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36705

Fix broken unit tests in ts_tcpip and test multiple simultaneous connections

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      Unit tests in ts_tcpip were broken, possibly by a timing change in Python. Make the tests robust by awaiting server.connect_task after making a client connection and before reading, writing, or checking connection state.

      Also test that only one client connects and the others are closed if several try to connect at the same time.

      Finally, modernize unit tests to use bare assert.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited
            Show
            rowen Russell Owen added a comment - - edited Pull request: https://github.com/lsst-ts/ts_tcpip/pull/17
            Hide
            wvreeven Wouter van Reeven added a comment -

            Reviewed on GitHub.

            Show
            wvreeven Wouter van Reeven added a comment - Reviewed on GitHub.
            Hide
            rowen Russell Owen added a comment -

            Tagged v0.4.2

            Show
            rowen Russell Owen added a comment - Tagged v0.4.2

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              wvreeven Wouter van Reeven
              Reviewers:
              Wouter van Reeven
              Watchers:
              Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.