Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36714

Evaluate the impact of imageCoCenter on AOS algorithm

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_aos
    • Labels:
      None

      Description

      Evaluate the impact of the imageCoCenter step on the retrieved Zernikes. Test whether the amount of imparted correction on the donut location makes any difference to the estimated wavefront. 

        Attachments

          Issue Links

            Activity

            Hide
            ksuberlak Krzysztof Suberlak added a comment - - edited

            In this notebook  https://github.com/suberlak/AOS/blob/main/AOS_DM-35922_cocenter_vs_recenter.ipynb   we find that the impact of shift applied at the imageCoCenter step (below 6 pixels) makes numerically no difference to the estimated Zernike coefficients. The magnitude of  co-center has to be increased beyond 9 pixels to make any  difference at all . The figure below shows results of a simulation of corner wavefront sensors. Regardless of donut location, the amount of cocenter shift needs to be increased beyond 9 px to make any difference from the baseline (no shift). 

            Show
            ksuberlak Krzysztof Suberlak added a comment - - edited In this notebook  https://github.com/suberlak/AOS/blob/main/AOS_DM-35922_cocenter_vs_recenter.ipynb    we find that the impact of shift applied at the imageCoCenter step (below 6 pixels) makes numerically no difference to the estimated Zernike coefficients. The magnitude of  co-center has to be increased beyond 9 pixels to make any  difference at all . The figure below shows results of a simulation of corner wavefront sensors. Regardless of donut location, the amount of cocenter shift needs to be increased beyond 9 px to make any difference from the baseline (no shift). 
            Hide
            ksuberlak Krzysztof Suberlak added a comment -

            Work documented in the notebook as well as ticket comments.

            Show
            ksuberlak Krzysztof Suberlak added a comment - Work documented in the notebook as well as ticket comments.
            Hide
            ajc Andrew Connolly added a comment -

            To close this out

            Show
            ajc Andrew Connolly added a comment - To close this out is the notebook in AOS analysis notebook repo? Can you add an introductory text including author and what versions of the software it runs under. See https://github.com/lsst-ts/ts_analysis_notebooks/blob/develop/aos/vignetting/wepVignettedPerformanceLimits.ipynb
            Hide
            ksuberlak Krzysztof Suberlak added a comment -

            Added an updated notebook (with introductory text and other structure) to https://github.com/lsst-ts/ts_analysis_notebooks/pull/31

            Show
            ksuberlak Krzysztof Suberlak added a comment - Added an updated notebook (with introductory text and other structure) to https://github.com/lsst-ts/ts_analysis_notebooks/pull/31
            Hide
            ajc Andrew Connolly added a comment -

            Looks good to me

             

            Show
            ajc Andrew Connolly added a comment - Looks good to me  
            Hide
            ajc Andrew Connolly added a comment -

            Updates look good

            Show
            ajc Andrew Connolly added a comment - Updates look good
            Show
            ksuberlak Krzysztof Suberlak added a comment - Adding a notebook link after the PR merge https://github.com/lsst-ts/ts_analysis_notebooks/blob/develop/aos/algorithm/imageCoCenterWithLsst.ipynb

              People

              Assignee:
              ksuberlak Krzysztof Suberlak
              Reporter:
              ksuberlak Krzysztof Suberlak
              Reviewers:
              Andrew Connolly
              Watchers:
              Andrew Connolly, Krzysztof Suberlak
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.