Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36718

Multi shapelet convolution test is very sensitive

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: shapelet
    • Labels:
      None
    • Story Points:
      0.5
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      After updating to macOS Ventura the shapelet test test_multiShapelet:testConvolveGaussians fails:

      tests/test_multiShapelet.py:89: 
      _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
      python/lsst/shapelet/tests.py:111: in compareMultiShapeletFunctions
          self.compareShapeletFunctions(sa, sb, rtolEllipse=rtolEllipse, rtolCoeff=rtolCoeff,
      python/lsst/shapelet/tests.py:86: in compareShapeletFunctions
          self.assertFloatsAlmostEqual(a.getEllipse().getParameterVector(),
      ../../stack/lsst-scipipe-4.1.0/Darwin/utils/g6f6f670c95+16108f2031/python/lsst/utils/tests.py:715: in assertFloatsAlmostEqual
          testCase.assertFalse(failed, msg="\n".join(errMsg))
      E   AssertionError: True is not false : 2/5 elements differ with rtol=1e-13, atol=1e-14
      E   17.0 != 13.999999999999998 (diff=3.0000000000000018/17.0=0.1764705882352942)
      E   2.4492935982947074e-16 != 2.9999999999999987 (diff=2.9999999999999982/2.9999999999999987=0.9999999999999999)
      

        Attachments

          Activity

          Hide
          tjenness Tim Jenness added a comment -

          The theory is that the test includes a sorting step to try to ensure that the components match but on macOS with Apple Silicon sometimes the two ixx values are very close and this can change the order of the components.

          Show
          tjenness Tim Jenness added a comment - The theory is that the test includes a sorting step to try to ensure that the components match but on macOS with Apple Silicon sometimes the two ixx values are very close and this can change the order of the components.
          Hide
          tjenness Tim Jenness added a comment -

          Sorting by sum of all the elements seems to work on Jenkins and on my Ventura mac.

          Show
          tjenness Tim Jenness added a comment - Sorting by sum of all the elements seems to work on Jenkins and on my Ventura mac.

            People

            Assignee:
            tjenness Tim Jenness
            Reporter:
            tjenness Tim Jenness
            Reviewers:
            Jim Bosch
            Watchers:
            Eli Rykoff, Jim Bosch, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.