Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36723

Many ts_standardscript unit tests failing in the conda build

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None

      Description

      The Jenkins.conda job for ts_standardscripts is failing with "UnboundLocalError: local variable 'process' referenced before assignment". This is almost certainly coming from BaseScriptTestCase.check_executable but can only occur if something else goes wrong.

      So: fix the unbound local variable problem, then try to fix whatever is triggering it.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          rowen Russell Owen added a comment - - edited

          Fixing the unbound variable exposed the true problem: a permission issue when trying to execute script files. This turns out to be a known issue and one we've decided to just live with (apparently we don't use the Conda builds of ts_standardscripts and ts_externalscripts). So this PR just has the fix for the unbound local variable.

          Pull request: https://github.com/lsst-ts/ts_standardscripts/pull/94

          Show
          rowen Russell Owen added a comment - - edited Fixing the unbound variable exposed the true problem: a permission issue when trying to execute script files. This turns out to be a known issue and one we've decided to just live with (apparently we don't use the Conda builds of ts_standardscripts and ts_externalscripts). So this PR just has the fix for the unbound local variable. Pull request: https://github.com/lsst-ts/ts_standardscripts/pull/94
          Hide
          Permalink
          wvreeven Wouter van Reeven added a comment -

          Reviewed on GitHub.

          Show
          wvreeven Wouter van Reeven added a comment - Reviewed on GitHub.
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Tagged ts_standardscripts v1.15.3

          Show
          rowen Russell Owen added a comment - Tagged ts_standardscripts v1.15.3

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Wouter van Reeven
            Watchers:
            Russell Owen, Tiago Ribeiro, Wouter van Reeven
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.