Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3677

HSC backport: Cleanup interpolation tasks and implement useFallbackValueAtEdge

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None

      Description

      This is a port of the changesets from:
      HSC-756

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            I suggest a default value for fallbackValueType instead of making it optional; it does no harm and simplifies use – even if useFallbackValueAtEdge defaults to False (though shouldn't it default to True – especially since that's what the repair task wants?).

            In that case the exception may be impossible to raise, so it's probably not worth trying to test it.

            Show
            rowen Russell Owen added a comment - - edited I suggest a default value for fallbackValueType instead of making it optional; it does no harm and simplifies use – even if useFallbackValueAtEdge defaults to False (though shouldn't it default to True – especially since that's what the repair task wants?). In that case the exception may be impossible to raise, so it's probably not worth trying to test it.
            Hide
            lauren Lauren MacArthur added a comment -

            There is indeed a default for fallbackValueType and useFallbackValueAtEdge does default to True. I suppose this check is slight overkill, but it does no harm and prints an informative error message in the off chance the user specifies a discordant set of values for these config parameters.

            Show
            lauren Lauren MacArthur added a comment - There is indeed a default for fallbackValueType and useFallbackValueAtEdge does default to True . I suppose this check is slight overkill, but it does no harm and prints an informative error message in the off chance the user specifies a discordant set of values for these config parameters.
            Hide
            lauren Lauren MacArthur added a comment -

            As for the defaults, I tried to set them to what they effectively were in interpolateOnePlane (then run!) in interpImage.py. In repair.py, as you pointed out in your initial review, the default fallbackValue was being set differently, so I included the setDefaults to reflect what was being used there. I'm inclined to leave that as is since it is not unreasonable to want different settings for certain defect types (e.g. true defective CCD pixels versus a mask plane). This could certainly be revisited if the interpImage task becomes more frequently implemented and the callers are finding that a different set of defaults would be more appropriate.

            Show
            lauren Lauren MacArthur added a comment - As for the defaults, I tried to set them to what they effectively were in interpolateOnePlane (then run!) in interpImage.py . In repair.py , as you pointed out in your initial review, the default fallbackValue was being set differently, so I included the setDefaults to reflect what was being used there. I'm inclined to leave that as is since it is not unreasonable to want different settings for certain defect types (e.g. true defective CCD pixels versus a mask plane). This could certainly be revisited if the interpImage task becomes more frequently implemented and the callers are finding that a different set of defaults would be more appropriate.
            Hide
            swinbank John Swinbank added a comment -
            Show
            swinbank John Swinbank added a comment - Hey Lauren MacArthur - would you mind writing a (brief!) summary of this for https://confluence.lsstcorp.org/display/DM/Data+Release+Production+WIP+W16+release+notes?
            Hide
            swinbank John Swinbank added a comment -

            Has been added to release notes – thanks!

            Show
            swinbank John Swinbank added a comment - Has been added to release notes – thanks!

              People

              Assignee:
              lauren Lauren MacArthur
              Reporter:
              lauren Lauren MacArthur
              Reviewers:
              Russell Owen
              Watchers:
              John Swinbank, Lauren MacArthur, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.