Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36778

Remove deprecated ref_dataset_name config from ap_verify testdata configs

    XMLWordPrintable

Details

    • Story
    • Status: To Do
    • Resolution: Unresolved
    • None
    • ap_verify
    • None
    • Data Release Production
    • No

    Description

      When running ap_verify locally, I noticed deprecation warnings because the config/calibrate.py in ap_verify_hits2015, ap_verify_ci_cosmos_pdr2, and ap_verify_ci_hits2015 override ref_dataset_name which has been deprecated. These should be removed.

      Attachments

        Activity

          lskelvin Lee Kelvin added a comment -

          Note: changes made on DM-38327 do not impact this ticket. That ticket removes the vestigial loadIndexedReferenceObjects.py file, but does not touch the replacement loadReferenceObjects.py file nor the deprecated ref_dataset_name config reported on this ticket.

          Testing was made to confirm the above, running:

          ap_verify.py \
          --dataset ap_verify_ci_cosmos_pdr2 \
          --output $BASEDIR \
          2>&1 | tee $BASEDIR/ap_verify_test.log
          

          which confirmed that the following error messages continue to appear:

          py.warnings WARNING: /sdf/group/rubin/user/lskelvin/repos/ap_verify_ci_cosmos_pdr2/config/calibrate.py:11: FutureWarning: Config field astromRefObjLoader.ref_dataset_name is deprecated: This field is not used. It will be removed after v25.
            config.astromRefObjLoader.ref_dataset_name = config.connections.astromRefCat
          ...
          

          lskelvin Lee Kelvin added a comment - Note: changes made on DM-38327 do not impact this ticket. That ticket removes the vestigial loadIndexedReferenceObjects.py file, but does not touch the replacement loadReferenceObjects.py file nor the deprecated ref_dataset_name config reported on this ticket. Testing was made to confirm the above, running: ap_verify.py \ --dataset ap_verify_ci_cosmos_pdr2 \ --output $BASEDIR \ 2>&1 | tee $BASEDIR/ap_verify_test.log which confirmed that the following error messages continue to appear: py.warnings WARNING: /sdf/group/rubin/user/lskelvin/repos/ap_verify_ci_cosmos_pdr2/config/calibrate.py:11: FutureWarning: Config field astromRefObjLoader.ref_dataset_name is deprecated: This field is not used. It will be removed after v25. config.astromRefObjLoader.ref_dataset_name = config.connections.astromRefCat ...

          People

            erykoff Eli Rykoff
            erykoff Eli Rykoff
            Eli Rykoff, Lee Kelvin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Jenkins

                No builds found.