Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36840

Evaluate the impact of imageCoCenter with AuxTel data

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_aos
    • Labels:

      Description

      Evaluate the impact of imageCoCenter with auxTel data . Consider whether this part  has been implemented correctly, given that field of view is a kwarg in `imageCoCenter` https://github.com/lsst-ts/ts_wep/blob/28ba52920896b412b6cdff6465af135c33860905/python/lsst/ts/wep/cwfs/CompensableImage.py#L273  , and it is not set when calling `imageCoCenter` in `Algorithm`  https://github.com/lsst-ts/ts_wep/blob/28ba52920896b412b6cdff6465af135c33860905/python/lsst/ts/wep/cwfs/Algorithm.py#L702  (thus it is always 3.5 deg).

       

       

        Attachments

          Issue Links

            Activity

            Hide
            ksuberlak Krzysztof Suberlak added a comment -

            Given the results of analysis in this notebook https://github.com/suberlak/AOS/blob/main/AOS_DM-36840_cocenter_auxTel_data.ipynb   `imageCoCenter` step has no impact on  running the CWFS code on `auxTel` images. Although the FOV is incorrect (`Algorithm` assumes the 3.5 degrees regardless of instrument) ,  the small  field distance (up to 6.7/2 arcmin for auxTel) means that the calculated shift is very small (less than 3.5 px for maximally distant donut):

               We find that the amount of `radialShift` has to be increased beyond 5.5 px to make any difference:

            To impart this amount of radialShift, `auxTel` donuts would  have to be outside of the field of view. Thus `imageCoCenter` can be safely removed when it comes to analysis of `auxTel` images. 

            Show
            ksuberlak Krzysztof Suberlak added a comment - Given the results of analysis in this notebook https://github.com/suberlak/AOS/blob/main/AOS_DM-36840_cocenter_auxTel_data.ipynb    `imageCoCenter` step has no impact on  running the CWFS code on `auxTel` images. Although the FOV is incorrect (`Algorithm` assumes the 3.5 degrees regardless of instrument) ,  the small  field distance (up to 6.7/2 arcmin for auxTel) means that the calculated shift is very small (less than 3.5 px for maximally distant donut):    We find that the amount of `radialShift` has to be increased beyond 5.5 px to make any difference: To impart this amount of radialShift, `auxTel` donuts would  have to be outside of the field of view. Thus `imageCoCenter` can be safely removed when it comes to analysis of `auxTel` images. 
            Hide
            ksuberlak Krzysztof Suberlak added a comment -

            Performed the analysis similar to https://jira.lsstcorp.org/browse/DM-36714 - the results support removal of `imageCoCenter` 

            Show
            ksuberlak Krzysztof Suberlak added a comment - Performed the analysis similar to https://jira.lsstcorp.org/browse/DM-36714  - the results support removal of `imageCoCenter` 

              People

              Assignee:
              ksuberlak Krzysztof Suberlak
              Reporter:
              ksuberlak Krzysztof Suberlak
              Reviewers:
              Bryce Kalmbach
              Watchers:
              Andrew Connolly, Bryce Kalmbach, Krzysztof Suberlak
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.