Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_cfht
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Science Pipelines DM-W16-1
-
Team:Alert Production
Description
The CFHT-specific CalibrateTask tries to apply aperture correction once just after measuring it (which is too early) and again later, at the right time. The error probably has no effect on the final results, but it is confusing and needlessly divergent from the standard CalibrateTask. The required changes are small. I plan to test by running Dominique Boutigny's CFHT demo.
Attachments
Activity
Ian: are you willing to have a look at this? If so, I suggest you compare CalibrateTask in pipe_tasks with the subclassed version in obs_cfht, focusing on areas where I made my changes (but anything else in the run method that looks wrong is fair game for questions or complaints).
Looks okay to merge.
Merged to master
I ran valid_cfht and all looks OK.
Note that valid_cfht turned out to have some bit rot: the astrometry_net_data config lists files that don't exist, which upsets the new astrometry index caching code. I updated valid_cfht on /lsst8/boutigny/valid_cfht/astrometry_net_data/andConfig.py accordingly. The config files one level up will also want changing from "root" to "config", but it's safer to hold off on that for awhile.