Details
-
Type:
Improvement
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_main_telescope
-
Labels:None
-
Story Points:2
-
Sprint:TSSW Sprint - Nov 07 - Nov 21
-
Team:Telescope and Site
Description
There are multiple configuration values triggering mirror failure due to HP excessive force (as measured by the load cell on top of the hardpoint):
HardpointMeasuredForceFaultHigh - which is never used in the code
HardpointMeasuredForceFSBWarningHigh - actually fault limit when force balancing is enabled
HardpointMeasuredForceWarningHigh - actual failure limit when force balancing is disabled
Either make sure the warning is really a warning and will not fault the mirror. Or drop all Warning, and replace those with Fault values.
Another possible solution is to specify failure values, and calculate warning values as fault values * ration configure for warning.
Attachments
Activity
I did not add these myself, they must have been in-progress by Chris when I took the branch to convert to SAL 4
Dave Mills
added a comment - I did not add these myself, they must have been in-progress by Chris when I took the branch to convert to SAL 4 Ok, I will fix those. Will discuss with M1M3 team on Friday meeting.
Petr Kubanek
added a comment - Ok, I will fix those. Will discuss with M1M3 team on Friday meeting. Result of discussion:
- only two levels, warning and error
- warning shall obviously issue warning (log entry), error shall panic/fault the mirror
- for the momement, balancing forces will be dropped, as mirror will exceed those when telescope is being moved. We might return those later as needed
- different values for compression/tension
Petr Kubanek
added a comment - Result of discussion:
only two levels, warning and error
warning shall obviously issue warning (log entry), error shall panic/fault the mirror
for the momement, balancing forces will be dropped, as mirror will exceed those when telescope is being moved. We might return those later as needed
different values for compression/tension
Petr Kubanek
added a comment - Please see PR:
https://github.com/lsst-ts/ts_m1m3support/pull/111
https://github.com/lsst-ts/ts_cRIOpy/pull/36 Reviewed ts_cRIOpy in GitHub.
Changes reviewed and merged.
Petr Kubanek
added a comment - Changes reviewed and merged. 
The checks were added in (mostly unrelated) commit "SAL 4 and XML 4.x compatible naming" by Dave Mills on Mar 9th 2020.