Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-36958

Deprecate deblend configs in characterizeImage

    XMLWordPrintable

    Details

      Description

      Merlin Fisher-Levine had trouble with CharacterizeImage which I strongly suspect was due to him setting doDeblend=True. Eli Rykoff and I both noted in the discussion that there is no reason we should have deblend options in characterize. This ticket is to mark the doDeblend and deblend config options as deprecated, for removal in v25.

      While I'm in there, I'll remove doApCorr from setDefaults: it's already True in the config!

        Attachments

          Issue Links

          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-36959 Remove doDeblend from characterizeImage

          • To Do

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Merlin Fisher-Levine: Well, this doesn't exactly fix the problem you had with a failure in source selection due to a non-contiguous catalog, but at least it will help future people not have the same problem.

            Show
            Parejkoj John Parejko added a comment - Merlin Fisher-Levine : Well, this doesn't exactly fix the problem you had with a failure in source selection due to a non-contiguous catalog, but at least it will help future people not have the same problem.
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment -

            Don't we usually RFC doing things like this? I want to at least have a chat with Eli and make sure there is a suitable replacement before removing this, even if it is nominally off because it "makes a mess". Once I've done that I'm happy to review though, of course.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Don't we usually RFC doing things like this? I want to at least have a chat with Eli and make sure there is a suitable replacement before removing this, even if it is nominally off because it "makes a mess". Once I've done that I'm happy to review though, of course.
            Hide
            Permalink
            mfisherlevine Merlin Fisher-Levine added a comment -

            (Also doesn't have to be Eli, he just offered. I'd very much up for removing it, I just want to make sure I can still get a certain thing done, so want to be sure of where removing this option from this point in the processing will leave things)

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - (Also doesn't have to be Eli, he just offered. I'd very much up for removing it, I just want to make sure I can still get a certain thing done, so want to be sure of where removing this option from this point in the processing will leave things)

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Merlin Fisher-Levine
              Watchers:
              Eli Rykoff, Ian Sullivan, Jim Bosch, John Parejko, Merlin Fisher-Levine, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.