Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3704

Refactor ImageDifferenceTask: Split into two tasks

    XMLWordPrintable

    Details

    • Story Points:
      10
    • Epic Link:
    • Sprint:
      AP S18-6, AP F18-1, AP F18-2, AP F18-3, AP F18-4, AP F18-5
    • Team:
      Alert Production

      Description

      This issue is to modernize the diffim task. Once it is running it should be refactored to use the new measurement tasks and reference loading wherever possible. Also remove any one off code used in past reports.

      Measurement should be split into its own task.

      The resulting task should be general, but not so general as to make it hard to run.

      This issue is being split into three issues:

      • DM-3704: split monolithic task into:
        • ImageDifferenceTask - creates image difference
        • ProcessDiffim - perform detection and measurement on image differences (and calexps)
      • DM-5294 Refactor/Clean up new ImageDifferenceTask
      • DM-5295 Refactor/Clean up new processDiffimTask

        Attachments

        1. script.sh
          5 kB
        2. script2.sh
          3 kB
        3. script3.sh
          4 kB

          Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-9989 Incorporate ZOGY and A&L decorrelation option into imageDifference.py

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5294 ImageDifferenceTask: Refactor Image DifferenceTask

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5295 Refactor processDiffim

          • Won't Fix
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3213 Get ImageDifferenceTask running again

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-10805 Spatially-varying ZOGY option

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11951 Fixes in AL Decorrelation and Zogy

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-11654 Refactor ZogyPsfMatch and ImagePsfMatch to inherit from an ABC

          • Won't Fix

          Improvement - An improvement or enhancement to an existing feature or task. DM-13831 Resolve outstanding issues for DM-3704 (DiffIm refactor)

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-6386 Create unit test(s) for imageDifference command-line task

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            5 older comments
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Note that I haven't forgotten it, there's just a lot of code to review. I've completed review of pipe_tasks, but am still working on ip_diffim (two files left).

            Show
            Parejkoj John Parejko added a comment - Note that I haven't forgotten it, there's just a lot of code to review. I've completed review of pipe_tasks, but am still working on ip_diffim (two files left).
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Review finished. See the PRs; pipe_tasks has a handful of changes, ip_diffim has many. I don't know who is supposed to be responsible for responding to the review.

            Show
            Parejkoj John Parejko added a comment - Review finished. See the PRs; pipe_tasks has a handful of changes, ip_diffim has many. I don't know who is supposed to be responsible for responding to the review.
            Hide
            Permalink
            reiss David Reiss added a comment -

            Thank you very much for the review, John Parejko! I will be happy to try to take a stab at many of your comments, and I hope that Yusra AlSayyad will try to help. Many of your questions (as you pointed out) are on code that was not written by me and I honestly don't know the answer to some of them. Perhaps Yusra AlSayyad or Simon Krughoff could help with some of those. The debugging code is particularly obscure and poorly documented and so may be the most difficult to fix (although I've heard that it is still potentially useful and we might want to keep it around for the time being).

            Show
            reiss David Reiss added a comment - Thank you very much for the review, John Parejko ! I will be happy to try to take a stab at many of your comments, and I hope that Yusra AlSayyad will try to help. Many of your questions (as you pointed out) are on code that was not written by me and I honestly don't know the answer to some of them. Perhaps Yusra AlSayyad or Simon Krughoff could help with some of those. The debugging code is particularly obscure and poorly documented and so may be the most difficult to fix (although I've heard that it is still potentially useful and we might want to keep it around for the time being).
            Hide
            Permalink
            mrawls Meredith Rawls added a comment -

            John Parejko and I are looking at this ticket today and seeing if we can clean up the review comments and merge.

            Show
            mrawls Meredith Rawls added a comment - John Parejko and I are looking at this ticket today and seeing if we can clean up the review comments and merge.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            This work will be taken into account in the new design being developed on DM-21304; it won't be completed/merged as is.

            Show
            swinbank John Swinbank added a comment - This work will be taken into account in the new design being developed on DM-21304 ; it won't be completed/merged as is.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              krughoff Simon Krughoff
              Reviewers:
              John Parejko
              Watchers:
              Colin Slater, David Reiss, John Parejko, John Swinbank, Meredith Rawls, Simon Krughoff, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: