Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-37130

Update default imgCloseLoop ISR settings

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_aos
    • Labels:

      Description

      DM-34989 changed the default ISR settings. Now running the `imgCloseLoop` creates non-uniform background: 

       

      The same sky file used before produced 

       

      This means adding the overscan setting to MEDIAN  https://github.com/lsst-ts/ts_phosim/blob/0858fc632e63686712189eb0ed928d3f84bd5cd6/python/lsst/ts/phosim/CloseLoopTask.py#L1142

        

        Attachments

          Issue Links

          is triggered by

          Improvement - An improvement or enhancement to an existing feature or task. DM-34989 Update obs_lsst to fix common problems.

          • Done
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-37160 Update ts_wep test data

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ksuberlak Krzysztof Suberlak added a comment -

            To make it clear: adding the 

            python: OverscanCorrectionTask.ConfigClass.fitType = 'MEDIAN'

            restores the previous clarity of the background; this was tested by running imgCloseLoop after the update.

            Show
            ksuberlak Krzysztof Suberlak added a comment - To make it clear: adding the  python: OverscanCorrectionTask.ConfigClass.fitType = 'MEDIAN' restores the previous clarity of the background; this was tested by running imgCloseLoop after the update.
            Hide
            Permalink
            ksuberlak Krzysztof Suberlak added a comment -

            PR merged on github

            Show
            ksuberlak Krzysztof Suberlak added a comment - PR merged on github
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Reviewed in GitHub.

            Show
            ttsai Te-Wei Tsai added a comment - Reviewed in GitHub.

              People

              Assignee:
              ksuberlak Krzysztof Suberlak
              Reporter:
              ksuberlak Krzysztof Suberlak
              Reviewers:
              Te-Wei Tsai
              Watchers:
              Krzysztof Suberlak, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.