Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-37130

Update default imgCloseLoop ISR settings

    XMLWordPrintable

Details

    • Improvement
    • Status: Done
    • Resolution: Done
    • None
    • ts_aos

    Description

      DM-34989 changed the default ISR settings. Now running the `imgCloseLoop` creates non-uniform background: 

       

      The same sky file used before produced 

       

      This means adding the overscan setting to MEDIAN  https://github.com/lsst-ts/ts_phosim/blob/0858fc632e63686712189eb0ed928d3f84bd5cd6/python/lsst/ts/phosim/CloseLoopTask.py#L1142

        

      Attachments

        1. image-2022-11-29-12-08-01-833.png
          477 kB
          Krzysztof Suberlak
        2. image-2022-11-29-12-08-55-951.png
          488 kB
          Krzysztof Suberlak
        3. image-2022-11-29-12-10-54-472.png
          473 kB
          Krzysztof Suberlak

        Issue Links

          Activity

            To make it clear: adding the 

            python: OverscanCorrectionTask.ConfigClass.fitType = 'MEDIAN'

            restores the previous clarity of the background; this was tested by running imgCloseLoop after the update.

            ksuberlak Krzysztof Suberlak added a comment - To make it clear: adding the  python: OverscanCorrectionTask.ConfigClass.fitType = 'MEDIAN' restores the previous clarity of the background; this was tested by running imgCloseLoop after the update.

            PR merged on github

            ksuberlak Krzysztof Suberlak added a comment - PR merged on github
            ttsai Te-Wei Tsai added a comment -

            Reviewed in GitHub.

            ttsai Te-Wei Tsai added a comment - Reviewed in GitHub.

            People

              ksuberlak Krzysztof Suberlak
              ksuberlak Krzysztof Suberlak
              Te-Wei Tsai
              Krzysztof Suberlak, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.